Scott Snyder authored Jul 11, 2022 and Tadej Novak committed Jul 11, 2022

AthenaKernel: Dependency tracking for conditions containers.

Allow conditions containers to manage lists of their dependencies.

2022-07-08: Daily merge of 22.0 into master

Closes ATR-25535

See merge request atlas/athena!54958

bugfix from coverity in NSWOfflineHelper.cxx

See merge request atlas/athena!54942

Shaun Roe authored Jul 08, 2022 and Walter Lampl committed Jul 08, 2022

bugfix from coverity in NSWOfflineHelper.cxx

manual cherry-pick of !54630: introduce a new set of ASG test files (ATLASG-1636)

See merge request atlas/athena!54879

Standalone track fitting demo using CUDA

See merge request atlas/athena!54443

Benjamin Michael Wynne authored Jul 08, 2022 and Walter Lampl committed Jul 08, 2022

Initial checkin, using Dmitry's code from AltEFTrack
 - compiles if you can get the Nvidia helper headers sorted
 - execution fails currently (lxplus-gpu)

Update trigger references for HLT enabling

See merge request atlas/athena!54925

Elin Bergeaas Kuutmann authored Jul 08, 2022 and Benjamin Philip Kerridge committed Jul 08, 2022

Update trigger references for HLT enabling

Electron ID for early run-3 data taking

See merge request atlas/athena!54930

Philip Sommer authored Jul 08, 2022 and Walter Lampl committed Jul 08, 2022

Electron ID for early run-3 data taking

ExpressionEvaluation: Fix cppcheck warnings.

See merge request atlas/athena!54904

Scott Snyder authored Jul 08, 2022 and Walter Lampl committed Jul 08, 2022

ExpressionEvaluation: Fix cppcheck warnings.

Fix cppcheck warnings.

DF-level trigger matching: Allow saving links not from owning containers

See merge request atlas/athena!54887

Jon Burr authored Jul 08, 2022 and Walter Lampl committed Jul 08, 2022

DF-level trigger matching: Allow saving links not from owning containers

2022-07-06: Daily merge of 22.0 into master

Closes ATR-25535

See merge request atlas/athena!54928

Merge branch 'nsw-decoder-features-and-fixes' into 'master'

Added a class to the offline helper to allow to build the ROB source ID from...

See merge request atlas/athena!54757

(cherry picked from commit b5cb0623)

9a346807 Check on module ID introduced in test program to avoid confusion with TP data.
9f77c6d0 Added a class to the offline helper to allow to build the ROB source ID from...
0a944953 test
a36e9306 adding robid preparation
11226d42 Apply 1 suggestion(s) to 1 file(s)
84518656 Apply 1 suggestion(s) to 1 file(s)
1fc5db44 Apply 1 suggestion(s) to 1 file(s)
99980d91 update
f99e97f2 Merge branch 'nsw-decoder-features-and-fixes' of...
05933844 remove cout
49e068e1 update
a1b92fae update

More changes to match CA config names to old + misc fixes

See merge request atlas/athena!54501

Edward Moyse authored Jul 08, 2022 and Julien Maurer committed Jul 08, 2022

Changes to fix some old-style/CA configuration differences.

To find these problems I hacked ToolSvc in Gaudi to warn about unconfigured tools with non-default names,
since for CA config this can mean that, rather being configured from a public tool as in old-style,
instead you get an unconfigued tool.
So it's a serious category of mis-configuration.

Some of the changes are to remove some of the worst false positives
(there are cases where a simple private tool really doesn't need configuration ... IMO we should just use the default name in such cases,
but I don't want CA and old-style naming differences until we have this migration finished).

Sweeping !54674 from master to 22.0.
MuonG4SD: const fixes and enable thread-checker

See merge request atlas/athena!54720

Adjust CaloBCIDLumiCondAlg unit test for the now mixed bx conditions container type.

See merge request atlas/athena!54846

Fix for muon LRT idperf chain

See merge request atlas/athena!54917

Savanna Shaw authored Jul 07, 2022 and Benjamin Philip Kerridge committed Jul 07, 2022

Fix for muon LRT idperf chain

Switching the LRT idperf chains to consider standalone muons in the hypo alg so as to not bias the ID performance measurements by requiring combined muons.

ATLASRECTS-7136: Fix for cases where impact parameter calculation fails

See merge request atlas/athena!54885

Dan Guest authored Jul 07, 2022 and Julien Maurer committed Jul 07, 2022

ATLASRECTS-7136: Fix for cases where impact parameter calculation fails

Adding protection against invalid identifiers

See merge request atlas/athena!54911

Edson Carquin Lopez authored Jul 07, 2022 and Julien Maurer committed Jul 07, 2022

Adding protection against invalid identifiers

Check containers exist in evtStore before using them

See merge request atlas/athena!54919

Tulay Cuhadar Donszelmann authored Jul 07, 2022 and Julien Maurer committed Jul 07, 2022

Check containers exist in evtStore before using them

Protection against using jobNumber incorrectly in simulation jobs

See merge request atlas/athena!54894

John Derek Chapman authored Jul 07, 2022 and Julien Maurer committed Jul 07, 2022

Protection against using jobNumber incorrectly in simulation jobs

Sweeping !54863 from master to 22.0.
CaloTPCnv: Fix roundtrip issue with CaloClusterCellLinkContainer.

See merge request atlas/athena!54888

Sweeping !54837 from master to 22.0.Add upgrade config in DL2 tagger tracks selection

See merge request atlas/athena!54891

Sweeping !54858 from master to 22.0.missing TileBadChannels conditions algorithm configuration... partially fixes ATR-25535

See merge request atlas/athena!54890

Sweeping !54757 from master to 22.0.
Added a class to the offline helper to allow to build the ROB source ID from...

See merge request atlas/athena!54889

Tau trigger EDM updates

See merge request atlas/athena!54886

Bertrand Martin Dit Latour authored Jul 07, 2022 and Benjamin Philip Kerridge committed Jul 07, 2022

Tau trigger EDM updates

Hello,

This MR is making the following adjustments to tau trigger EDM:
* the tau clusters and tau vertex containers are currently written in AODCOMM mode, but these containers are required for tau algorithm tunings, so they are moved to AODFULL
* we are missing the `CENTER_MAG` cluster moment, which is used by vertexed clusters in the [recalculation of eta/phi](https://gitlab.cern.ch/atlas/athena/-/blob/master/Event/xAOD/xAODCaloEvent/Root/CaloVertexedTopoCluster.cxx#L73-95). There is a suspicion that this is causing irreproducibility in the tau ID tuning when we recompute cluster-based HLT variables at AOD level (this cluster moment is available at HLT runtime, but in the AOD it's not and a value of 0 is silently used). The moment is added to TriggerEDMRun3 as it's not part of the static Aux EDM (CaloClusterTrigAuxContainer), and declared as a new float decoration in TriggerEDMAuxAccessors.

Cheers,
Bertrand

TrigVrtSecInclusive: downgrade printout from INFO to DEBUG

See merge request atlas/athena!54897

Bertrand Martin Dit Latour authored Jul 07, 2022 and Benjamin Philip Kerridge committed Jul 07, 2022

TrigVrtSecInclusive: downgrade printout from INFO to DEBUG

Hello,

While running tests, I noticed some INFO messages appearing quite often (once per event?):
```
7:33:38 TrigVrtSecInclusive                      444   2    INFO UTT> primary vertex successfully retrieved
17:33:38 TrigVrtSecInclusive_TrigDV               444   2    INFO UTT> primary vertex successfully retrieved
```

I assume we can safely downgrade from INFO to DEBUG, to reduce the size of log files :-)

Tagging Takane and Kunihiro for confirmation.

Cheers,
Bertrand