Yes, I think we should try to understand the underlying reason we need this sleep time. If we can change that with a much shorter set of idles, for instance, or if it's felix-software driven how we can avoid that overall.
This branch implements the firmware-based trigger generation for ITk pixels with FelixClient. In addition to that, there are also a few more changes in the TxCore of Felix Client library to make the YARR scans work with libfabric without RDMA.
Looks good to me. I've left only one small comment
can we resolve this "TODO" item?
make it an error, not an info
instead of 2
use sizeof
move to an enum
leftover. should be removed from this one
say it's strip specific, move next to the pixel one. Add more comments.
same comment as below, let's use a safe default
check why this has moved to 1
. Put a reasonable default in case enableMonitor
is set to true
rename the variable to make it clear it's pixel-specific
indeed, see also my comment below. I would love if we can have this setup from the chip class rather than the controller.
I still would love if this can be configured via the chip class instead. I'll have a look at the code to see if I can come up with a concrete suggestion
This all logic only works on a single channel. Shouldn't that be fid-specific?