From ab115d080d36f9cca0141f401bb41e3d4719e86b Mon Sep 17 00:00:00 2001
From: Scott Snyder <scott.snyder@cern.ch>
Date: Fri, 23 Jan 2015 21:29:13 +0100
Subject: [PATCH] Fix coverity warnings. (OffloadSvc-00-00-06)

	* Tagging OffloadSvc-00-00-06.
	* src/OffloadSvc.cxx: Fix coverity warnings.
---
 Offloading/OffloadSvc/src/OffloadSvc.cxx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Offloading/OffloadSvc/src/OffloadSvc.cxx b/Offloading/OffloadSvc/src/OffloadSvc.cxx
index f645de36055..8ac02c7162d 100644
--- a/Offloading/OffloadSvc/src/OffloadSvc.cxx
+++ b/Offloading/OffloadSvc/src/OffloadSvc.cxx
@@ -75,6 +75,7 @@ StatusCode OffloadSvc::sendData(std::unique_ptr<APE::BufferContainer> &buff, int
   m_mySocket->send(APE::BufferAccessor::getRawBuffer(*buff),buff->getTransferSize());
   ts.sendEnd=std::chrono::system_clock::now();
   ts.uploadSize=buff->getTransferSize();
+  ts.downloadSize = 0;
   m_stats[token]=ts;
   return StatusCode::SUCCESS;  
 }
@@ -182,20 +183,20 @@ StatusCode OffloadSvc::initialize()
     std::unique_lock<std::mutex> lock(m_cMutex);
     ATH_MSG_INFO("Waiting for connections");
     if(m_tCond.wait_for(lock,std::chrono::milliseconds(3000))==std::cv_status::timeout){
-      ATH_MSG_ERROR("Error while openning connection to APE! Timeout while trying to open the connection");
+      ATH_MSG_ERROR("Error while opening connection to APE! Timeout while trying to open the connection");
       t->detach();
       delete t;
       return StatusCode::FAILURE;
     }else{
       ATH_MSG_INFO ("Connection successfully opened");
-      return StatusCode::SUCCESS;
       if(m_isConnected){
 	t->join();
 	delete t;
       }
+      return StatusCode::SUCCESS;
     }
   }catch(std::exception &ex){
-    ATH_MSG_ERROR("Error while openning connection to APE! "<<ex.what());    
+    ATH_MSG_ERROR("Error while opening connection to APE! "<<ex.what());    
     m_isConnected=false;
     return StatusCode::FAILURE;
   }
-- 
GitLab