Does the old code cause segfaults in normal running?
Maybe I'm missing something but it would mean that the list of lines is different depending on which event with the same TCK, I'm looking at. I find this slightly confusing and it will make generic monitoring of especially this line together with others more complicated.
I don't doubt that the decoders can handle this well.
If one prepares a sample which is enriched with physics, it should be possible to test the mechanics of the chain with a handful of events (and a handful of lines as you suggest) in a nightly test.
More and more lines want to add decision filters (!3213 (comment 7776560), !3107, !3212) and probably more should. I would suggest we fix the necessary tests so that we can move on.
I would just change that the TCK is like 0xFAFAFAFA
. 0x00000000
is probably also used for other things.
I understood that the TCK includes the decoding key but maybe I'm wrong. This might be a bit confusing then. Not sure if it is an actual problem since the decoders look at the decoding key I think and not at the TCK.
Yes my question was triggered by looking at the MR to the file-content-metadata repo. I have to say, I'm not sure if this behaviour has consequences downstream. If at all the TCK should probably have a very special and reserved number as well.
Can you test here if the Passthrough line is in the list of lines and if not add it?
Sorry for my ignorance, does this mean that the events triggered by this line have a special TCK and decoding key?
And because it would likely crash half of the tests.
Not sure where to comment, so I do it here. There are probably more technical and calibration lines which should be excluded from normal Hlt2 lines. So the current implementation ('Hlt1(?!PassthroughLargeEvent).*Decision') in !3212 is probably not complete.
You mean the issue that the lines can't run on samples without Hlt1Dec- and Hlt1SelReports?
Sascha Stahl (36aff05c) at 25 Mar 15:44
Fixed formatting
Sascha Stahl (aa8268ad) at 25 Mar 15:42
Thanks @gunther !
As discussed via mattermost, I moved the function around. I guess we should test again.
Done, please check
Sascha Stahl (84f9a309) at 25 Mar 15:32
Fixed formatting
Sascha Stahl (a9bbbd30) at 25 Mar 15:28
move around lines