From 2b7ab0d2052c25314e76192b533e20f89a507b06 Mon Sep 17 00:00:00 2001
From: Frank Winklmeier <Frank.Winklmeier@cern.ch>
Date: Tue, 26 Apr 2016 16:10:33 +0200
Subject: [PATCH] Remove obsolete shifter link from summary table
(TrigValTools-00-04-25)
* bin/atn_summary.pl: Remove obsolete shifter link
* TrigValTools-00-04-25
2016-05-21 Stewart Martin-Haugh <smh@cern.ch>
* bin/dumpTimers.py: fix overflow finding
* TrigValTools-00-04-24
Former-commit-id: 6af5a14f25164673a6b132e6648e9f738f3b15b4
---
Trigger/TrigValidation/TrigValTools/bin/atn_summary.pl | 7 -------
Trigger/TrigValidation/TrigValTools/bin/dumpTimes.py | 6 +++---
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/Trigger/TrigValidation/TrigValTools/bin/atn_summary.pl b/Trigger/TrigValidation/TrigValTools/bin/atn_summary.pl
index 51831f2bae9..3eb76301892 100755
--- a/Trigger/TrigValidation/TrigValTools/bin/atn_summary.pl
+++ b/Trigger/TrigValidation/TrigValTools/bin/atn_summary.pl
@@ -339,13 +339,6 @@ function showBuildFailures(failures,link) {
}
print "Nightly wiki page name using postfix: $nightlywiki\n";
-# print HTMLOUT "<p>Shifter: before modifing the wiki test that you are authenticated <A HREF=\"https://twiki.cern.ch/twiki/bin/view/Atlas/TriggerValidationATNStatusDummy\" onClick=\"return popup(this, 'notes')\">here</A><br>\n";
-# doesnt' work print HTMLOUT <A HREF=\"https://login.cern.ch/adfs/ls/?wa=wsignout1.0\"> logout </A> \n";
-
-# print HTMLOUT "Update wiki with problems common to multiple tests <A HREF=\"https://twiki.cern.ch/twiki/bin/view/Atlas/TriggerValidationATNStatus$nightlywiki#Current_issues_in_nightly_ATN_te\" onClick=\"return popup(this, 'notes')\">here</A> </p>\n";
-
- print HTMLOUT "<p><b>Shifter:</b> <a href=\"https://savannah.cern.ch/bugs/?group=atlas-trig&func=browse&set=custom&msort=0&custom_sb6[]=101&assigned_to[]=0&date[]=1900-1-1&priority[]=0&resolution_id=3,4,5,8,100,101,378&severity[]=0&status_id[]=1&release[]=&fix_release[]=&date_op[]=%3E&advsrch=0&msort=0&chunksz=150&spamscore=5&report_id=378&sumORdet=&morder=resolution_id<,bug_id>&order=bug_id#results\">Click here</a> to get a list of Savannah bugs flagged as affecting ATLAS nightlies. Please create a new bug report, with \"Affects ATN\" set to true for all issues not listed there.</p>";
-
print HTMLOUT "\n<table class=\"sortable\" id=\"ATNResults\" border=1><thead><tr>
<th title=\"Click to sort by test suite\">Test name</th>
<th>Wiki</th>
diff --git a/Trigger/TrigValidation/TrigValTools/bin/dumpTimes.py b/Trigger/TrigValidation/TrigValTools/bin/dumpTimes.py
index bf96ee749e0..c6353ec28cb 100755
--- a/Trigger/TrigValidation/TrigValTools/bin/dumpTimes.py
+++ b/Trigger/TrigValidation/TrigValTools/bin/dumpTimes.py
@@ -17,11 +17,11 @@ def timing(hist):
if hist.GetEntries() == 0:
return "0"
mean_plus_err = str(round(mean,3)) + " +/- " + str(round(error,3))
- overflow = str(hist.GetBinContent(hist.GetNbinsX()+1))
- if overflow != 0.0:
+ overflow = hist.GetBinContent(hist.GetNbinsX()+1)
+ if overflow == 0.0:
return mean_plus_err
else:
- return mean_plus_err + "\nOverflow: " + overflow
+ return mean_plus_err + "\tOverflow: " + str(overflow)
def match(pattern, name):
--
GitLab