From 63a58bb3f1ab836b0ca960e9ec16a5c322df41f7 Mon Sep 17 00:00:00 2001
From: Vadim Kostyukhin <vkost@cern.ch>
Date: Mon, 2 Feb 2015 16:55:16 +0100
Subject: [PATCH] Correct Coverity 13032,12177,12643 issues
(VxSecVertex-00-04-05)
* Correct Coverity 13032,12177,12643 issues
* Tagged as VxSecVertex-00-04-05
---
.../VxSecVertex/VxSecVertex/VxSecVKalVertexInfo.h | 2 +-
Tracking/TrkEvent/VxSecVertex/src/VxSecVKalVertexInfo.cxx | 8 ++++++--
Tracking/TrkEvent/VxSecVertex/src/VxSecVertexInfo.cxx | 2 +-
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Tracking/TrkEvent/VxSecVertex/VxSecVertex/VxSecVKalVertexInfo.h b/Tracking/TrkEvent/VxSecVertex/VxSecVertex/VxSecVKalVertexInfo.h
index 43ae66cec7a..e0d0e234186 100755
--- a/Tracking/TrkEvent/VxSecVertex/VxSecVertex/VxSecVKalVertexInfo.h
+++ b/Tracking/TrkEvent/VxSecVertex/VxSecVertex/VxSecVKalVertexInfo.h
@@ -63,7 +63,7 @@ namespace Trk {
virtual VxSecVKalVertexInfo* clone() const;
/* assignment operator */
- VxSecVKalVertexInfo operator= (const VxSecVKalVertexInfo &);
+ VxSecVKalVertexInfo& operator= (const VxSecVKalVertexInfo &);
/* destructor */
virtual ~VxSecVKalVertexInfo();
diff --git a/Tracking/TrkEvent/VxSecVertex/src/VxSecVKalVertexInfo.cxx b/Tracking/TrkEvent/VxSecVertex/src/VxSecVKalVertexInfo.cxx
index bd0588a9786..03f875a32d3 100755
--- a/Tracking/TrkEvent/VxSecVertex/src/VxSecVKalVertexInfo.cxx
+++ b/Tracking/TrkEvent/VxSecVertex/src/VxSecVKalVertexInfo.cxx
@@ -23,7 +23,11 @@
namespace Trk {
VxSecVKalVertexInfo::VxSecVKalVertexInfo() :
- VxSecVertexInfo() {}
+ VxSecVertexInfo(),
+ m_mass(0.),
+ m_energyFraction(0.),
+ m_energyTrkInJet(0.),
+ m_n2trackvertices(0){}
VxSecVKalVertexInfo::VxSecVKalVertexInfo(const std::vector<xAOD::Vertex*> & vertices,
double mass,double energyFraction,int n2trackvertices,double energyTrkInJet,
@@ -78,7 +82,7 @@ namespace Trk {
m_badTracksIP(rhs.m_badTracksIP)
{}
- VxSecVKalVertexInfo VxSecVKalVertexInfo::operator= (const VxSecVKalVertexInfo & rhs) {
+ VxSecVKalVertexInfo & VxSecVKalVertexInfo::operator= (const VxSecVKalVertexInfo & rhs) {
if (this!=&rhs) {
this->operator=(rhs);
diff --git a/Tracking/TrkEvent/VxSecVertex/src/VxSecVertexInfo.cxx b/Tracking/TrkEvent/VxSecVertex/src/VxSecVertexInfo.cxx
index 102208e8b93..346ee36a1ea 100755
--- a/Tracking/TrkEvent/VxSecVertex/src/VxSecVertexInfo.cxx
+++ b/Tracking/TrkEvent/VxSecVertex/src/VxSecVertexInfo.cxx
@@ -79,8 +79,8 @@ namespace Trk {
std::cout << " Warning in VxSecVertexInfo: tried in copy constructor to copy over a zero pointer Vertex " << std::endl;
}
}
+ m_SVOwnership=false;
}
- m_SVOwnership=false;
return *this;
}
--
GitLab