From bdcd12f7528c9d5f95878e7be2ca756e3449896e Mon Sep 17 00:00:00 2001
From: Alejandro Alonso Diaz <alejandro.alonso@cern.ch>
Date: Fri, 25 Nov 2016 15:06:08 +0100
Subject: [PATCH] Update minSecondaryTRTPrecFrac to 0.3
 (InDetRecExample-02-06-08-02)

	* loosened TRT precision hit fraction cut to recover TRT extension
	  efficiency (ATLASRECTS-3526).
	* Update minSecondaryTRTPrecFrac to 0.3
	* Tagging as InDetRecExample-02-06-08-02

2016-11-18 Goetz Gaycken
	* loosened TRT precision hit fraction cut to recover TRT extension
	  efficiency (ATLASRECTS-3526).
	* Tuning of TRT PID to get good efficiency and fake rate up to a mu of
	  60 (ATLASRECTS-2102, obo Kerstin Tackman, Ludovica Aperio Bella).


Former-commit-id: 96684f16b35f4969c505bf67d68fcf303feb33eb
---
 .../InDetRecExample/python/ConfiguredNewTrackingCuts.py     | 4 ++--
 .../InDetRecExample/python/ConfiguredSecondaryVertexCuts.py | 6 +++---
 .../InDetRecExample/share/ConfiguredTRTStandalone.py        | 3 ++-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredNewTrackingCuts.py b/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredNewTrackingCuts.py
index f7820436d3d..363768340d5 100755
--- a/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredNewTrackingCuts.py
+++ b/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredNewTrackingCuts.py
@@ -59,7 +59,7 @@ class ConfiguredNewTrackingCuts :
 
     # --- this is for the TRT-extension
     self.__minTRTonTrk             = 9
-    self.__minTRTPrecFrac          = 0.5
+    self.__minTRTPrecFrac          = 0.3
 
     # --- general pattern cuts for NewTracking
     self.__radMax                  = 600. * Units.mm # default R cut for SP in SiSpacePointsSeedMaker
@@ -173,7 +173,7 @@ class ConfiguredNewTrackingCuts :
       self.__maxSecondaryPixelHoles    = 1                # tighten hole cuts 
       self.__maxSecondarySCTHoles      = 1                # tighten hole cuts 
       self.__maxSecondaryDoubleHoles   = 0                # tighten hole cuts 
-      self.__minSecondaryTRTPrecFrac   = 0.5              # default for all tracking now, as well for BackTracking
+      self.__minSecondaryTRTPrecFrac   = 0.3              # default for all tracking now, as well for BackTracking
       self.__rejectShortExtensions     = True             # fall back onto segment if TRT extension is short
       self.__SiExtensionCuts           = True             # use cuts from ambi scoring already early
       # self.__maxSecondaryTRTShared     = 0.2              # tighen shared hit cut for segment maker ?
diff --git a/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredSecondaryVertexCuts.py b/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredSecondaryVertexCuts.py
index 24ad5117cdb..7fb36d35233 100644
--- a/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredSecondaryVertexCuts.py
+++ b/InnerDetector/InDetExample/InDetRecExample/python/ConfiguredSecondaryVertexCuts.py
@@ -176,7 +176,7 @@ class ConfiguredSecondaryVertexCuts :
 
       if mode == "ConversionPileUp" or mode == "EGammaPileUp":
         # ------------------------------------
-        # --- cut tuning for 17.2
+        # --- cut tuning for 21.X
         # ------------------------------------
 
         # Track selector tool
@@ -184,7 +184,7 @@ class ConfiguredSecondaryVertexCuts :
         self.__TrkSel_RatioCut1                  = 0.0    # UNCHANGED, e-prob: Ntrt < 15
         self.__TrkSel_RatioCut2                  = 0.1    # UNCHANGED, e-prob: 15 < Ntrt < 25  
         self.__TrkSel_RatioCut3                  = 0.1    # UNCHANGED, e-prob: Ntrt > 25
-        self.__TrkSel_RatioTRT                   = 0.7    # new e-prob cut for TRT only from Bruno
+        self.__TrkSel_RatioTRT                   = 0.75   # new e-prob cut for TRT-TRT only conversion
         
         # Track pairs selector
         self.__TrkPairSel_MaxDistBetweenTracks   = [10.*Units.mm,50.*Units.mm,50.*Units.mm]       # UNCHANGED, minimum distance cut at vertex (Mauro 10,100,50)
@@ -210,7 +210,7 @@ class ConfiguredSecondaryVertexCuts :
         self.__SingleTrk_MaxBLayerHits              = 0                # UNCHANGED, no blayer hits on single track conversion
         self.__SingleTrk_MinInitialHitRadius        =  70.*Units.mm    # UNCHANGED, start conversion in layer 1
         self.__SingleTrk_MinInitialHitRadius_noBlay = 120.*Units.mm    # but allow for conversion tracks starting in layer 2 if blayer is dead        
-        self.__SingleTrk_MinRatioOfHLhits           = 0.7              # e-prob cut, Bruno prefered 0.8
+        self.__SingleTrk_MinRatioOfHLhits           = 0.85             # e-prob cut single-TRT converison 
 
     else:
       print "*********************** ERROR, wrong configuration for Configured Secondary Vertex Cuts !!!"
diff --git a/InnerDetector/InDetExample/InDetRecExample/share/ConfiguredTRTStandalone.py b/InnerDetector/InDetExample/InDetRecExample/share/ConfiguredTRTStandalone.py
index cd684a577d3..1b6dae5930d 100644
--- a/InnerDetector/InDetExample/InDetRecExample/share/ConfiguredTRTStandalone.py
+++ b/InnerDetector/InDetExample/InDetRecExample/share/ConfiguredTRTStandalone.py
@@ -66,7 +66,8 @@ class ConfiguredTRTStandalone:
                                                                      minTRTonTrk         = NewTrackingCuts.minTRTonly(),
                                                                      maxEta              = 2.1,
                                                                      UseParameterization = NewTrackingCuts.useTRTonlyParamCuts(),
-                                                                     OldTransitionLogic  = NewTrackingCuts.useTRTonlyOldLogic())
+                                                                     OldTransitionLogic  = NewTrackingCuts.useTRTonlyOldLogic(),
+                                                                     minTRTPrecisionFraction = NewTrackingCuts.minSecondaryTRTPrecFrac())
     # InDetTRT_StandaloneScoringTool.OutputLevel = VERBOSE 
     ToolSvc += InDetTRT_StandaloneScoringTool
     if (InDetFlags.doPrintConfigurables()):
-- 
GitLab