Indeed, but, as I understand it, subfolders under the compact/runX
folders are not meant to be created by the subdetectors but by the project maintainers. @mexu - can you comment on this?
The changes to the compact/components/TV
area look good to me. As I see, the diff between trunk
and trunk_Sx_H
is:
--- trunk/parameters.xml 2024-03-21 08:54:49.648582813 +0000
+++ trunk_Sx_H/parameters.xml 2024-03-21 08:55:00.125690189 +0000
@@ -173,7 +173,7 @@
<!-- CYLINDRICAL FOIL SETTINGS -->
<!-- For the Cylindical Foil, placed here for convinience -->
- <constant name="TV:CylindRFFoilThickness" value="0.075*mm"/>
+ <constant name="TV:CylindRFFoilThickness" value="0.150*mm"/>
@@ -885,7 +885,7 @@
</material>
<material name = "TV:SubstrateSilicon" state="solid" >
- <D type="density" unit="g/cm3" value="2.3300"/>
+ <D type="density" unit="g/cm3" value="4.6600"/>
<fraction n="1" ref = "Silicon"/>
</material>
So doubling the material of the foil and substrate.
However, I'm not sure we're meant to create new folders under compact/run5
, that should be done by the project maintainers. What is the intention behind that new folder? If it's just to allow to easily run a debug xml then we could probably just create new files in the existing debug folder.
As just discussed on Mattermost, indeed any future changes will need to be appropriately propagated between the two subfolders. It should just become part of the checks for any future MR touching the TV xml to ensure that the diff between trunk
and trunk_Sx_H
is still as intended.
Thomas Latham (cc15c615) at 20 Mar 19:43
run5-tmp
branchValidated by
Thomas Latham (30301285) at 19 Mar 22:40
Small modification setting the maximum values to lower value.
... and 21 more commits
Thomas Latham (f7f493b1) at 19 Mar 22:40
Small modification setting the maximum values to lower value.
... and 1 more commit
Thomas Latham (8aaae599) at 19 Mar 17:36
Fix lvFoot envelope z-size
Thomas Latham (fde3ded1) at 19 Mar 16:49
Merge branch 'peilian_TV_newlayout_32stations' into 'future_upgrade...
... and 1 more commit
Thomas Latham (a36ec949) at 19 Mar 16:43
update TV layout to be 32 stations assuming 90% hit efficiency
... and 4 more commits
To fix the overlapping of supportive foot ends with more stations, by removing the extending part of the ends. Also comment out some lines that could be a bug.
Validated by
Thomas Latham (906b1d94) at 19 Mar 16:42
Merge branch 'wangy_fix_TV_support_overlap' into 'future_upgrades_s...
... and 1 more commit
To fix the overlapping of supportive foot ends with more stations, by removing the extending part of the ends. Also comment out some lines that could be a bug.
Validated by
Thomas Latham (9b98db45) at 19 Mar 16:34
Small fix, combine uncessary box cuts.
... and 6 more commits
Thomas Latham (ae20dcaa) at 19 Mar 16:29
Add simplified versions of LV cabling
... and 1 more commit