Simon Mazenoux requested to merge SIGMON-526_add_check_for_pic into dev Oct 23, 2023

Context

Missing PIC check in the 'Pm timestamps' check.

What was done

renaming 'Pm timestamps' class that now query data from both pm and nxcals
add tests for the new code

TODO

Figure out where to get the spark instance in a production environment (could be nice to have an instance during local development, especially to patch directly the spark data query instead of having to patch dataframes that might change.
Create a test with real data in case we want to implement dependency injection for tests (real vs fake environment)

QA

code was unit tested
acceptance tests were written

Review objectives

assessment of code functionality
assessment of code quality
identifying potential refactorings / logic common to other projects