lhc-sm-hwc merge requestshttps://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests2024-03-28T09:28:30+01:00https://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests/197[SIGMON-672] replace %matplotlib widget by %matplotlib notebook2024-03-28T09:28:30+01:00Simon Mazenoux[SIGMON-672] replace %matplotlib widget by %matplotlib notebookCloses SIGMON-672Closes SIGMON-672Simon MazenouxSimon Mazenouxhttps://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests/196Draft: [SIGMON-658] No notebooks content checks2024-03-26T16:56:12+01:00Aleksandra MnichDraft: [SIGMON-658] No notebooks content checks# Context
* issue:
# What was done
* `test_notebooks.py` updated so that the content of the executed notebook is not checked
* reference `.html` and `.ipyn` files removed
* `notebooks_exec_requirements.txt` updated to the new Softw...# Context
* issue:
# What was done
* `test_notebooks.py` updated so that the content of the executed notebook is not checked
* reference `.html` and `.ipyn` files removed
* `notebooks_exec_requirements.txt` updated to the new Software Stack on SWAN
Closes SIGMON-658Aleksandra MnichAleksandra Mnichhttps://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests/195SIGMON-649_logging_grouping_by_tags_demo2024-03-26T17:33:08+01:00Alexandra MurariuSIGMON-649_logging_grouping_by_tags_demo# Context
* Project(s) README(s) link(s)
* Story reminder
* Task details
* ? other related reviews
* ? are superseded reviews closed?
# What was done
* keypoints of the implementation / code changes
* why was this solution prefer...# Context
* Project(s) README(s) link(s)
* Story reminder
* Task details
* ? other related reviews
* ? are superseded reviews closed?
# What was done
* keypoints of the implementation / code changes
* why was this solution preferred over another?
* ? what could be improved on?
# TODO
* ? Anything still to be done?
# QA
* template link to sonar issues:http://sonar/component_issues/index?id=_GROUP_%3A_ARTIFACT_#resolved%3Dfalse%7Cauthors%3D_PAIR1_%2C_PAIR2_
* code was unit tested | was not unit tested, because...
* acceptance tests were written | not written, because...
# Review objectives
* ? assessment of code functionality
* ? assessment of code quality
* ? identifying potential refactorings / logic common to other projects
* ? knowledge sharing
* ? getting help to understand a piece of code
Closes SIGMON-649Alexandra MurariuAlexandra Murariuhttps://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests/194[SIGMON-644] Implement PCC.4 notebook2024-03-18T21:18:12+01:00Agnieszka Chmielinska[SIGMON-644] Implement PCC.4 notebook# What was done
* Notebook for PCC.4 analysis
# TODO
* \---
Closes SIGMON-644# What was done
* Notebook for PCC.4 analysis
# TODO
* \---
Closes SIGMON-644Agnieszka ChmielinskaAgnieszka Chmielinskahttps://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests/161[SIGMON-537] implement new analysis notebook for pli2.f32023-12-20T14:22:34+01:00Simon Mazenoux[SIGMON-537] implement new analysis notebook for pli2.f3# Context
* Agnieszka implemented the notebook for the pli2_f3 analysis class (available here https://its.cern.ch/jira/browse/SIGMON-535), but the analysis logic needed to be extracted.
# What was done
* implement pli2.f3 analysis
* i...# Context
* Agnieszka implemented the notebook for the pli2_f3 analysis class (available here https://its.cern.ch/jira/browse/SIGMON-535), but the analysis logic needed to be extracted.
# What was done
* implement pli2.f3 analysis
* implement corresponding notebook
# TODO
* ?
# QA
* code was not unit tested (it's a notebook)
* acceptance tests were written
# Review objectives
* ? assessment of code functionality
* ? assessment of code qualitySimon MazenouxSimon Mazenouxhttps://gitlab.cern.ch:8443/LHCData/lhc-sm-hwc/-/merge_requests/158Draft: [SIGMON-524] update the AN_IPQ_PLI1.c3 notebook to use the new analysi...2024-03-28T08:52:58+01:00Simon MazenouxDraft: [SIGMON-524] update the AN_IPQ_PLI1.c3 notebook to use the new analysis classCloses SIGMON-524Closes SIGMON-524Simon MazenouxSimon Mazenoux