Skip to content

For Gcc13/c++20: remove errant template arguments in constructors

Andre Sailer requested to merge sailer/RooUnfold:fixCPP20 into master

We are integrating gcc13/c++20 in the LCG builds, and RooUnfold 3.0.0 has some issues with that. This patch fixes those problems. If you ever have a new tag we should deploy, please let us know at https://sft.its.cern.ch/jira/browse/SPI

Cheers, Andre

Fixes errors like:

/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfold.h:60:28: error: expected unqualified-id before 'const'
   60 |   RooUnfoldT<Hist,Hist2D> (const RooUnfoldResponseT<Hist,Hist2D>* res, const Hist* meas, const char* name= 0, const char* title= 0);
      |                            ^~~~~
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfold.h:60:28: error: expected ')' before 'const'
   60 |   RooUnfoldT<Hist,Hist2D> (const RooUnfoldResponseT<Hist,Hist2D>* res, const Hist* meas, const char* name= 0, const char* title= 0);
      |                           ~^~~~~
      |                            )
[ 26%] Building CXX object CMakeFiles/RooUnfold.dir/src/RooUnfoldFitHelpers.o
In file included from /build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooFitUnfold.cxx:3:
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfold.h:60:28: error: expected unqualified-id before 'const'
   60 |   RooUnfoldT<Hist,Hist2D> (const RooUnfoldResponseT<Hist,Hist2D>* res, const Hist* meas, const char* name= 0, const char* title= 0);
      |                            ^~~~~
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfold.h:60:28: error: expected ')' before 'const'
   60 |   RooUnfoldT<Hist,Hist2D> (const RooUnfoldResponseT<Hist,Hist2D>* res, const Hist* meas, const char* name= 0, const char* title= 0);
      |                           ~^~~~~
      |                            )
In file included from /build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfoldErrors.h:20,
                 from /build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfoldErrors.cxx:33:
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfold.h:60:28: error: expected unqualified-id before 'const'
   60 |   RooUnfoldT<Hist,Hist2D> (const RooUnfoldResponseT<Hist,Hist2D>* res, const Hist* meas, const char* name= 0, const char* title= 0);
      |                            ^~~~~
/build/jenkins/workspace/lcg_nightly_pipeline/build/frameworks/RooUnfold-3.0.0/src/RooUnfold/3.0.0/src/RooUnfold.h:60:28: error: expected ')' before 'const'
   60 |   RooUnfoldT<Hist,Hist2D> (const RooUnfoldResponseT<Hist,Hist2D>* res, const Hist* meas, const char* name= 0, const char* title= 0);
      |                           ~^~~~~
      |                            )

Merge request reports