Skip to content

Converter for generic trapezoid for the surface model

Severin Diederichs requested to merge generic_trap_converter_clean into surface_model

This MR adds the generic trap (Arb8) converter for the surface model. The second order surfaces are called Arb4 in the surface model. Similarly to the torus, the frame check is done automatically when computing the intersection, so they have no frame themselves. A gdml is added.

This first implementation retrieved the algorithms for intersection and safety from the solid model. A bounding prism to accelerate the computation is not yet implemented.

Furthermore, this MR adds the hash for the cone and fixes the performance bottleneck of the hashing. For invalid surfaces, they previously would always get the hash 0, leading to many surfaces with hash 0 which ended up in a very expensive loop although there was no common surface to be found.

A few missing data deletions of the torus were added.

Merge request reports