When fetch_reference_ivs() is called, it should crash if it cannot find a reference IV instead of returning None
The problem here is that we end up creating an aux.json
file that just contains 'null'
which is loaded back as None
in module-qc-analysis-tools, which then crashes.
>>> import json
>>> aux_json = json.dumps(None)
>>> itemdata = json.loads(aux_json)
>>> if not isinstance(itemdata, list):
... itemdata = [itemdata]
...
>>> itemdata
[None]
So there's two ways forward.
- we keep current behavior, but add logic in the
analyze_measurement
and check if the return isNone
and say something like "if module and no reference IV" -- either warn and say it will skip the comparison, or crash because we require bare module reception reference IV - we fix mqat to allow for None, but this sounds like a silent failure to me and im worried we can't identify this after the fact...