Skip to content
Snippets Groups Projects

fix bug in SubVolumeConfig

Merged Julia Hrdinka requested to merge bug_SubVolumeConfig into release-0.03.X
1 unresolved thread

Fixes ACTS-261.

Merge request reports

Pipeline #89931 failed

Pipeline failed for f2548dfe on bug_SubVolumeConfig

Approval is optional

Merged by avatar (Mar 14, 2025 1:38pm UTC)

Merge details

  • Changes merged into with 6ffb8b1a.
  • Deleted the source branch.

Pipeline #90149 failed

Pipeline failed for 6ffb8b1a on release-0.03.X

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
189 185 ///| Negative Endcap | Barrel | Positive Endcap | => four boundaries needed in
190 186 /// z
191 187 /// | Barrel | => two boundaries needed in z
192 /// the zBoundaries do not need to be handed over sorted, they will be sorted
193 /// in ascending order automatically
188 /// @note the zBoundaries need to be handed over sorted in ascending order
194 189 std::vector<double> zBoundaries;
195 190
196 191 /// Default constructor
197 SubVolumeConfig() : present(false), rMin(10e10), rMax(10e-10), zBoundaries()
198 {
199 if (zBoundaries.size() > 1 && rMin >= 0. && rMax > 0.) present = true;
200 // make sure the zBoundaries are sorted in ascending order
201 std::sort(zBoundaries.begin(), zBoundaries.end());
202 }
192 SubVolumeConfig() : rMin(10e10), rMax(10e-10), zBoundaries() {}
  • :negative_squared_cross_mark: Jenkins Build FAILURE

    Results available at: Jenkins [ACTS-MERGE #78]

  • :negative_squared_cross_mark: Jenkins Build FAILURE

    Results available at: Jenkins [ACTS-MERGE #79]

  • :negative_squared_cross_mark: Jenkins Build FAILURE

    Results available at: Jenkins [ACTS-MERGE #93]

  • Julia Hrdinka added 1 commit

    added 1 commit

    • f2548dfe - give new default values for rMin & rMax and check if rMin < rMax

    Compare with previous version

  • :negative_squared_cross_mark: Jenkins Build FAILURE

    Results available at: Jenkins [ACTS-MERGE #94]

  • Christian Gumpert Approved this merge request

    Approved this merge request

  • mentioned in commit 6ffb8b1a

  • Please register or sign in to reply
    Loading