Remove all mutable statics in the ACTS codebase

While looking around for pointer-to-mutables, I found a bug caused by a mutable static class member in KalmanUpdator, so I decided to get rid of all remaining mutable statics in ACTS.

This fixes ACTS-309.

Found 17 files with missing MPLv2 license statement:
Core/src/Surfaces/RectangleBounds.cpp
Core/src/Surfaces/LineBounds.cpp
Core/src/Surfaces/TrapezoidBounds.cpp
Core/src/Surfaces/RadialBounds.cpp
Core/src/Surfaces/TriangleBounds.cpp
Core/include/ACTS/Surfaces/BoundaryCheck.hpp
Core/include/ACTS/Surfaces/EllipseBounds.hpp
Core/include/ACTS/Surfaces/TrapezoidBounds.hpp
Core/include/ACTS/Surfaces/LineBounds.hpp
Core/include/ACTS/Surfaces/RectangleBounds.hpp
Core/include/ACTS/Surfaces/PlanarBounds.hpp
Core/include/ACTS/Surfaces/RadialBounds.hpp
Core/include/ACTS/Surfaces/TriangleBounds.hpp
Core/include/ACTS/Surfaces/DiscTrapezoidalBounds.hpp
Core/include/ACTS/Surfaces/SurfaceBounds.hpp
Core/include/ACTS/Surfaces/InfiniteBounds.hpp
Core/include/ACTS/Utilities/detail/RealQuadraticEquation.hpp

added 1 commit

• 38ce3caa - Remove all mutable statics in the ACTS codebase

Compare with previous version

test coverage result:
Overall coverage rate:
lines......: 34.0% (2853 of 8401 lines)
functions..: 45.2% (1036 of 2290 functions)

full test results can be found here

doxygen output:
0 errors
57 warnings
full doxygen output can be found here

Jenkins Build SUCCESS

Results available at: Jenkins [ACTS-MERGE #216]

Found 17 files with missing MPLv2 license statement:
Core/src/Surfaces/RectangleBounds.cpp
Core/src/Surfaces/LineBounds.cpp
Core/src/Surfaces/TrapezoidBounds.cpp
Core/src/Surfaces/RadialBounds.cpp
Core/src/Surfaces/TriangleBounds.cpp
Core/include/ACTS/Surfaces/BoundaryCheck.hpp
Core/include/ACTS/Surfaces/EllipseBounds.hpp
Core/include/ACTS/Surfaces/TrapezoidBounds.hpp
Core/include/ACTS/Surfaces/LineBounds.hpp
Core/include/ACTS/Surfaces/RectangleBounds.hpp
Core/include/ACTS/Surfaces/PlanarBounds.hpp
Core/include/ACTS/Surfaces/RadialBounds.hpp
Core/include/ACTS/Surfaces/TriangleBounds.hpp
Core/include/ACTS/Surfaces/DiscTrapezoidalBounds.hpp
Core/include/ACTS/Surfaces/SurfaceBounds.hpp
Core/include/ACTS/Surfaces/InfiniteBounds.hpp
Core/include/ACTS/Utilities/detail/RealQuadraticEquation.hpp

test coverage result:
Overall coverage rate:
lines......: 34.0% (2853 of 8401 lines)
functions..: 45.2% (1036 of 2290 functions)

full test results can be found here

doxygen output:
0 errors
57 warnings
full doxygen output can be found here

Jenkins Build SUCCESS

Results available at: Jenkins [ACTS-MERGE #217]

mentioned in merge request !295 (merged)

added 1 commit

• 4d28cee9 - Backported Kalman updator static fix from unique_ptr MR

Compare with previous version

Found 17 files with missing MPLv2 license statement:
Core/src/Surfaces/RectangleBounds.cpp
Core/src/Surfaces/LineBounds.cpp
Core/src/Surfaces/TrapezoidBounds.cpp
Core/src/Surfaces/RadialBounds.cpp
Core/src/Surfaces/TriangleBounds.cpp
Core/include/ACTS/Surfaces/BoundaryCheck.hpp
Core/include/ACTS/Surfaces/EllipseBounds.hpp
Core/include/ACTS/Surfaces/TrapezoidBounds.hpp
Core/include/ACTS/Surfaces/LineBounds.hpp
Core/include/ACTS/Surfaces/RectangleBounds.hpp
Core/include/ACTS/Surfaces/PlanarBounds.hpp
Core/include/ACTS/Surfaces/RadialBounds.hpp
Core/include/ACTS/Surfaces/TriangleBounds.hpp
Core/include/ACTS/Surfaces/DiscTrapezoidalBounds.hpp
Core/include/ACTS/Surfaces/SurfaceBounds.hpp
Core/include/ACTS/Surfaces/InfiniteBounds.hpp
Core/include/ACTS/Utilities/detail/RealQuadraticEquation.hpp

added 1 commit

• 43450b8e - Remove all mutable statics in the ACTS codebase

Compare with previous version

I also backported the Kalman Updator fix from !295 (merged) here, since it's a better place and it will allow for faster merging.

test coverage result:
Overall coverage rate:
lines......: 33.9% (2849 of 8397 lines)
functions..: 45.2% (1035 of 2289 functions)

full test results can be found here

doxygen output:
0 errors
57 warnings
full doxygen output can be found here

Jenkins Build SUCCESS

Results available at: Jenkins [ACTS-MERGE #218]

Found 17 files with missing MPLv2 license statement:
Core/src/Surfaces/RectangleBounds.cpp
Core/src/Surfaces/LineBounds.cpp
Core/src/Surfaces/TrapezoidBounds.cpp
Core/src/Surfaces/RadialBounds.cpp
Core/src/Surfaces/TriangleBounds.cpp
Core/include/ACTS/Surfaces/BoundaryCheck.hpp
Core/include/ACTS/Surfaces/EllipseBounds.hpp
Core/include/ACTS/Surfaces/TrapezoidBounds.hpp
Core/include/ACTS/Surfaces/LineBounds.hpp
Core/include/ACTS/Surfaces/RectangleBounds.hpp
Core/include/ACTS/Surfaces/PlanarBounds.hpp
Core/include/ACTS/Surfaces/RadialBounds.hpp
Core/include/ACTS/Surfaces/TriangleBounds.hpp
Core/include/ACTS/Surfaces/DiscTrapezoidalBounds.hpp
Core/include/ACTS/Surfaces/SurfaceBounds.hpp
Core/include/ACTS/Surfaces/InfiniteBounds.hpp
Core/include/ACTS/Utilities/detail/RealQuadraticEquation.hpp

test coverage result:
Overall coverage rate:
lines......: 33.9% (2849 of 8397 lines)
functions..: 45.2% (1035 of 2289 functions)

full test results can be found here

doxygen output:
0 errors
57 warnings
full doxygen output can be found here

Jenkins Build SUCCESS

Results available at: Jenkins [ACTS-MERGE #219]

marked as a Work In Progress

This needs to be updated to accomodate for the changes of !293 (merged).

added 43 commits

• 43450b8e...3c303b6d - 42 commits from branch acts:master
• ab39aa1b - Remove all mutable statics in the ACTS codebase

Compare with previous version

unmarked as a Work In Progress

...and now it's ready to go in again.

test coverage result:
Overall coverage rate:
lines......: 34.7% (2992 of 8617 lines)
functions..: 46.8% (1099 of 2350 functions)

full test results can be found here

doxygen output:
0 errors
108 warnings
full doxygen output can be found here

Jenkins Build SUCCESS

Results available at: Jenkins [ACTS-MERGE #227]

approved this merge request

Hi @hgraslan,

looks good to me. Could you please rebase? I will merge this in afterwards.

Thanks, Christian

added 15 commits

• ab39aa1b...b2eb68c1 - 14 commits from branch acts:master
• b4aa3410 - Remove all mutable statics in the ACTS codebase

Compare with previous version

Done!

test coverage result:
Overall coverage rate:
lines......: 34.7% (2993 of 8624 lines)
functions..: 46.8% (1099 of 2350 functions)

full test results can be found here

doxygen output:
0 errors
107 warnings
full doxygen output can be found here

Jenkins Build SUCCESS

Results available at: Jenkins [ACTS-MERGE #239]

approved this merge request

mentioned in commit 2df036aa

merged

changed milestone to %0.04.01