Skip to content
Snippets Groups Projects

Removes all warnings in current acts-core built

Merged Andreas Salzburger requested to merge ACTS-386_Remove_brackets_warnings into master

Fixes ACTS-386

Wrong bracketing syntax fixed Some unused variables removed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hadrien Benjamin Grasland approved this merge request

    approved this merge request

  • Awesome!

    The clang build looks good, the gcc build still contains a few warnings:

    [87/201] Building CXX object Plugins/DD4hepPlugins/CMakeFiles/ACTSDD4hepPlugin.dir/src/ConvertDD4hepDetector.cpp.o
    ../Plugins/DD4hepPlugins/src/ConvertDD4hepDetector.cpp: In function 'std::unique_ptr<const Acts::TrackingGeometry> Acts::convertDD4hepDetector(dd4hep::DetElement, Acts::Logging::Level, Acts::BinningType, Acts::BinningType, Acts::BinningType, double, double, bool)':
    ../Plugins/DD4hepPlugins/src/ConvertDD4hepDetector.cpp:107:16: warning: variable 'endCapRmin' set but not used [-Wunused-but-set-variable]
             double              endCapRmin = 0.;
                    ^~~~~~~~~~
    ../Plugins/DD4hepPlugins/src/ConvertDD4hepDetector.cpp:108:16: warning: variable 'barrelRmin' set but not used [-Wunused-but-set-variable]
             double              barrelRmin = 0.;
                    ^~~~~~~~~~
    [103/201] Building CXX object Tests/Fitter/CMakeFiles/KalmanFilterTest.dir/KalmanFilterTests.cpp.o
    ../Tests/Fitter/KalmanFilterTests.cpp: In function 'std::vector<boost::variant<boost::detail::variant::over_sequence<boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)2>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)2, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)2, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)2, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)1, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)2>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)2, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)2, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)2, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)0, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)2>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)2, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)2, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)2, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)1, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)2>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)2, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)2, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)2, (Acts::ParDef)3, (Acts::ParDef)4>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)3>, boost::mpl::v_item<Acts::Measurement<long int, (Acts::ParDef)4>, boost::mpl::vector<Acts::Measurement<long int, (Acts::ParDef)3, (Acts::ParDef)4>, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na, mpl_::na>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1>, 1> > > > generateDummyMeasurements(Acts::BoundParameters, std::shared_ptr<Acts::IExtrapolationEngine>, std::shared_ptr<const Acts::TrackingGeometry>)':
    ../Tests/Fitter/KalmanFilterTests.cpp:55:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if (id >= exCell.extrapolationSteps.size() - 1) continue;
             ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    Do we want to fix those as well?

  • Sure ! And I need to clang-format the files.

  • added 1 commit

    • 3f9fb0f9 - fixing gcc warnings as well

    Compare with previous version

  • Ok, done. I still have clang-formatting differences on my laptop, so the clang-format will fail, but otherwise this should be good to go !

  • Hadrien Benjamin Grasland approved this merge request

    approved this merge request

  • Paul Gessinger added 1 commit

    added 1 commit

    • cafcc0b7 - fix format of changed files

    Compare with previous version

  • Ah, my fixes created a new warning ... will remove this one. We seemed to have a cascade of non-used variables in the DD4hepBuilder.

  • added 1 commit

    • 97b81d7c - removing unused rMin variable

    Compare with previous version

  • All fixed, an done ... who wants to approve ?

  • Paul Gessinger approved this merge request

    approved this merge request

  • Hadrien Benjamin Grasland approved this merge request

    approved this merge request

  • mentioned in commit 08900cb9

  • mentioned in issue #387 (closed)

  • ATS Jenkins changed milestone to %0.05.02

    changed milestone to %0.05.02

Please register or sign in to reply
Loading