Make some geometry helper methods public

Previously they were private or protected, but they can be very useful outside. To prevent copy-paste code reuse, I made them public here.

I can simplify some code in the ATLAS Calo geometry construction with these methods. Any objections to make them public?

changed milestone to %0.09.00

added Improvement Needs Decision labels

For job clang_tidy on commit: c0137c7f

Static analysis results: Accepted

ok	pattern	count	limit
	readability-inconsistent-declaration-parameter-name	0	0
	readability-named-parameter	0	0
	readability-container-size-empty	0	0
	modernize-use-using	0	0
	modernize-use-override	0	0
	readability-implicit-bool-cast	0	0
	modernize-use-default-member-init	0	0
	performance-unnecessary-value-param	0	0
	modernize-use-equals-default	0	0
	modernize-use-nullptr	0	0

Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/551/clang_tidy

added 3 commits

• c0137c7f...beffc7f9 - 2 commits from branch master
• 94074c32 - Make some geometry helper methods public

Compare with previous version

added 3 commits

• 94074c32...b795f71d - 2 commits from branch master
• 077a31ee - Make some geometry helper methods public

Compare with previous version

For job clang_tidy on commit: 077a31ee

Static analysis results: Accepted

ok	pattern	count	limit
	readability-inconsistent-declaration-parameter-name	0	0
	readability-named-parameter	0	0
	readability-container-size-empty	0	0
	modernize-use-using	0	0
	modernize-use-override	0	0
	readability-implicit-bool-cast	0	0
	modernize-use-default-member-init	0	0
	performance-unnecessary-value-param	0	0
	modernize-use-equals-default	0	0
	modernize-use-nullptr	0	0

Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/551/clang_tidy

added 3 commits

• 077a31ee...e26e95f9 - 2 commits from branch master
• aa16cb1f - Make some geometry helper methods public

Compare with previous version

For job clang_tidy on commit: aa16cb1f

Static analysis results: Accepted

ok	pattern	count	limit
	readability-inconsistent-declaration-parameter-name	0	0
	readability-named-parameter	0	0
	readability-container-size-empty	0	0
	modernize-use-using	0	0
	modernize-use-override	0	0
	readability-implicit-bool-cast	0	0
	modernize-use-default-member-init	0	0
	performance-unnecessary-value-param	0	0
	modernize-use-equals-default	0	0
	modernize-use-nullptr	0	0

Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/551/clang_tidy

added 3 commits

• aa16cb1f...ef313a41 - 2 commits from branch master
• d172ae1b - Make some geometry helper methods public

Compare with previous version

approved this merge request

Non-controversial. I am approving this.

For job clang_tidy on commit: d172ae1b

Static analysis results: Accepted

ok	pattern	count	limit
	readability-inconsistent-declaration-parameter-name	0	0
	readability-named-parameter	0	0
	readability-container-size-empty	0	0
	modernize-use-using	0	0
	modernize-use-override	0	0
	readability-implicit-bool-cast	0	0
	modernize-use-default-member-init	0	0
	performance-unnecessary-value-param	0	0
	modernize-use-equals-default	0	0
	modernize-use-nullptr	0	0

Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/551/clang_tidy

added 5 commits

• d172ae1b...26649fdb - 4 commits from branch master
• 19c0f7de - Make some geometry helper methods public

Compare with previous version

approved this merge request

added 11 commits

• 19c0f7de...2d133a21 - 10 commits from branch master
• ddea470f - Make some geometry helper methods public

Compare with previous version

approved this merge request

approved this merge request

enabled an automatic merge when the pipeline for ddea470f succeeds

merged

mentioned in commit 1881a601