New seedfinder

New seedfinder

New detector independent seedfinder implementation based on the ATLAS implementation. I tried to encapsulate parts that may be detector specific in tools. Please tell me where more comments are required. Templated on SpacePoint, returns a vector of vectors with results to avoid locking a single output container. To allow parallelization, the user calls createSeedsForRegion with an iterator, and for each of these regions a separate output container is filled. Less fine grained than per-spacepoint: ATLAS configuration would mean 260 parallelizable regions (independent of # of measurements).

Functionality to be added later: Returning an iterator that hides the looping over vector of vectors. Reducing bin size (increasing parallelism, reducing combinatorics), currently prevented by performance overhead from AnyGrid.

Find the delta to ATLAS Seeding

approved this merge request

Great to see this coming in, I have a few naming suggestions and a general one on the interface.

We also need to make some rule how we call typename templates, in most of the code we have done this now with deliberately saying propagator_t, which in this case would be spacepoint_t, or -- what I would actually like even more external_spacepoint_t and you see immediately in the code where external from internal decouples and couples.

thanks for the comments, I'll also change the template names

added 1 commit

• 760006c3 - changed pointers to references

Compare with previous version

added 1 commit

• 7c9cae72 - renamed Legacy Seedfinder

Compare with previous version

added 1 commit

• a455099e - clang tidy

Compare with previous version

For job clang_tidy on commit: a455099e

Static analysis results: Accepted

ok	pattern	count	limit
	readability-inconsistent-declaration-parameter-name	0	0
	readability-named-parameter	0	0
	readability-container-size-empty	0	0
	modernize-use-using	0	0
	modernize-use-override	0	0
	readability-implicit-bool-cast	0	0
	modernize-use-default-member-init	0	0
	performance-unnecessary-value-param	0	0
	modernize-use-equals-default	0	0
	modernize-use-nullptr	0	0

Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/556/clang_tidy

mentioned in merge request !557 (closed)

changed milestone to %0.09.00

added New Feature label

approved this merge request

added 88 commits

• a455099e...082358b9 - 45 commits from branch master
• 3535dd18 - new seedfinder restructured, removed traces of from-scratch-seedfinder
• 59f8ce05 - removed mixed seeds specific code
• 57103a8e - made the seeding work :)
• af2930d2 - removed bugs, fixed error calculation, cleaned up comments
• 81fd825d - remove Seeding namespace
• 5696bb3d - changed paths from ACTS to Acts
• 7adadd69 - code cleanup
• 35be2280 - changed seedmaker interface, renamed state & config, store indices instead of external space points
• 71dc1689 - add plural include and library paths in generated config
• 1e2825b6 - SP type erasure to template, fix curbin index in state
• 27e5a371 - move covariance tool out of config to avoid templating everything, check if...
• 009d197d - move test spacepoints into test
• deb095ee - include Definitions.hpp where it is needed
• 805991eb - moved ATLAS Seeding into Legacy namespace, New Seedfinder now produces...
• 954cea72 - removed shared pointers where not necessary for 10x speedup, restored overwritten CMakeLists.txt
• 18824528 - performance opts and more comments
• 1d3360c1 - changed interface to expose parallelizable loop to user
• 2e8728b3 - fix bugs, remove default config
• 53372536 - templated everything on spacepoint, binning still hard wired to ATLAS values
• a642bd64 - changed from iterating over spacepoints to iterating over grid bins, output...
• f1cd2f7c - removed warnings and added license statements
• 86b51d5e - applied clang format
• 590c7359 - add Seeding tests to CMakeLists files
• 45f9d656 - moved Tests/Seeding/ into Tests/Core/Seeding and corrected wrongly merged files
• bee760e6 - fixed license format and removed debug fragment from GridTests
• fb57798b - appeasing the license and format scripts
• 4abf3bca - virtual destructor in SeedFilter
• 37949c5d - added virtual destructors to classes with virtual methods
• 2614310a - clang format
• fe98b9e7 - removing test for Space Point Triplet inputs
• d1d80418 - remove remnants of removed TripletTest from CmakeLists, fix bad automerged ActsConfig.cmake
• dd3d20b8 - make clang-tidy happy
• 51f60440 - another round of clang format
• 8998f14a - making clang compiler happy
• e7fb1af6 - format
• 4293e281 - bug in ATLAS Binfinders fixed
• 48241f95 - remove unused vars
• 974474c8 - apply clang tidy suggestions
• 82d21021 - shared to raw pointer interface and improved comments
• 1f233097 - clang format
• 583882f1 - changed pointers to references
• 79131ce3 - renamed Legacy Seedfinder
• 42340617 - clang tidy

Compare with previous version