Multi adaptive vertex fitter
Implements the multi adaptive vertex fitter and all related required tools.
Edited by Bastian Schlag
Merge request reports
Activity
Filter activity
added New Feature label
For job clang_tidy on commit: c24dbbce
Static analysis results: Failed
ok pattern count limit 
readability-inconsistent-declaration-parameter-name0 0 readability-named-parameter0 0 readability-container-size-empty0 0 modernize-use-using0 0 modernize-use-override0 0 readability-implicit-bool-cast0 0 
modernize-use-default-member-init2 0 performance-unnecessary-value-param0 0 modernize-use-equals-default0 0 modernize-use-nullptr0 0 Analysis results at: https://acts.web.cern.ch/ACTS/static_analysis/acts-core/mr/566/clang_tidy
@bschlag is that a
v0.10.00target ?
Nope, the
IterativeVertexFinder!535 (merged) is, however.added 1 commit
- 40b8ae8d - SequentialVertexSmoother with unit tests added
added 270 commits
-
40b8ae8d...baf83685 - 197 commits from branch
master - 1e1355d4 - FsmwMode1dFinder and TrackToVertexIPEstimator added
- 5228f5c1 - ZScanSeedFinder added
- 391a7929 - introduced some Vertexing directory substructure
- c7b1acb1 - added missing includes
- eba08951 - templated TrackToVertexIPEstimator and ZScanFinder, added unit tests for both
- 5654dda7 - unit tests for user-defined InputTrack added
- f1873754 - renamed ZScanFinder -> ZScanVertexFinder
- 323d6fb4 - added VertexingStatus to be returned by finders
- e95d4de5 - rename findVertex function in find
- a1c54713 - add template param BField to ZScanFinder
- 6c990790 - first version of IterativeVertexFinder, seed finding and fitting, no track removal yet
- 7ea7a1ba - added functionality to reassign tracks after first fit in vertex finder, added associated functions
- 04ee89a1 - completed reassignTracksAfterFirstFit case
- 9fd86429 - added function to remove compatible tracks and outliers at end of finder iteration
- a0ac7c58 - first working version of IterativeVertexFinder, split functionality in more...
- ceaefb92 - removed hard-coded billoir fitter from finder, store unique_ptr of IVertexFinder in config now
- a61fb370 - bug fixed, use always last seed in collection for selecting compatible tracks
- b6a335e5 - bugs fixed, set maxVertices to 50 and increment iterator when reassigning tracks
- 928687d0 - full IterativeVertexFinder unit test working now with random number of...
- 482d18f5 - remove unused variable
- c8690e43 - fix format
- ee0e24e1 - bug fixed, use last seed in seed collection also for constraint fits
- 9cfbadb9 - change position component get methods in unit test
- bd00cba5 - fix format
- 32c2489e - reduced number of test cases in iterative vertex finder test
- e6dcbd3b - simplified LinTrackFactory argument in config
- e07238f1 - adapt after rebase
- 592676df - clang tidy
- 03034b07 - bug fixed
- d202bfdd - move propagator from find function argument list to config
- e04f2ca6 - move debug bool to cfg
- 3d475209 - bug fix, fix format
- 9e601eb2 - added some documentation
- 55959479 - fix format
- 286d1689 - added logging to IterativeVertexFinder and moved ZScanVertexFinder from...
- 8840e46b - going back to flat directory hierachy
- 1378eeb3 - added correct IVertexFitter version
- 12fc9a9d - introduced geo and bfield context to vertex finder
- be9266aa - added some documentation for ImpactPoint3dEstimator
- 40bb8fe3 - added countSignificantTracks to IterativeVertexFinder and some documentation
- 955f82d4 - remove camel case from template params
- 7429ef55 - Use boost shared lib for all unit tests
- 8eeb906c - add const keyword to find function
- 6312b624 - format fix and FsmwMode1dFinder reference
- bef78ae0 - Apply suggestion to Core/include/Acts/Vertexing/IterativeVertexFinder.ipp
- 8ff1ff34 - Apply suggestion to Core/include/Acts/Vertexing/IterativeVertexFinder.ipp
- 7a3fb621 - Apply suggestion to Core/include/Acts/Vertexing/ZScanVertexFinder.ipp
- 5fd65f4d - use fixed seed for unit tests
- 972c4cc3 - docs update
- ba2d1c6e - more docs updates
- bfcfe471 - variable rename
- bc162ab6 - format
- 8c6f9507 - some minor changes
- 3e072b06 - add error handling to all methods in IterativeVertexFinder
- c512073a - replace longish iterator type with auto
- b331ec68 - update docs
- 0043991a - add some doc comments
- de51ffd1 - bug fix, set new tracksAtVertex after removing of outliers after fit and some minor changes
- 43c37754 - algorithm description added to hpp
- e218e972 - Update IterativeVertexFinder.hpp
- 2a65be63 - remove perigeeList filled in every iteration and use seedTracks instead directly
- 7d696f4c - docs updated
- fc4ac291 - clang tidy
- 3096ff54 - vertex annealing tool for MAVFitter started
- 9fb73773 - VertexAnnealingTool implemented with getWeight() methods
- 916ec452 - use std::exp instead of exp
- c2cad34f - add correct libraries
- b8ce789c - added first VertexAnnealingTool unit tests
- 376e835b - unit test for VertexAnnealingTool for multi chi2 added
- 9e993c16 - implementation of KalmanVertexTrackUpdator started
- 217fe670 - format
- d33b54a9 - KalmanVertexUpdator added, KalmanVertexTrackUpdator implementation continued
- 13ed6f27 - SequentialVertexSmoother with unit tests added
Toggle commit list-
40b8ae8d...baf83685 - 197 commits from branch
-
For job clang_tidy on commit: 4275f382
Static analysis results: Failed
ok pattern count limit readability-inconsistent-declaration-parameter-name0 0 readability-named-parameter0 0 readability-container-size-empty0 0 modernize-use-using0 0 modernize-use-override0 0 readability-implicit-bool-cast0 0 modernize-use-default-member-init2 0 performance-unnecessary-value-param0 0 modernize-use-equals-default0 0 modernize-use-nullptr0 0 Analysis results at: https://gitlab.cern.ch/api/v4/projects/3031/jobs/3953026/artifacts
added 137 commits
-
4275f382...c8199504 - 62 commits from branch
master - e623439d - FsmwMode1dFinder and TrackToVertexIPEstimator added
- 65dcef83 - ZScanSeedFinder added
- b6ab6b02 - introduced some Vertexing directory substructure
- bbe0bc66 - added missing includes
- 8befd947 - templated TrackToVertexIPEstimator and ZScanFinder, added unit tests for both
- 4961d93f - unit tests for user-defined InputTrack added
- ae7cb5d3 - renamed ZScanFinder -> ZScanVertexFinder
- 1c27d43d - added VertexingStatus to be returned by finders
- cd8472b2 - rename findVertex function in find
- 143f6493 - add template param BField to ZScanFinder
- 0dfdb3ee - first version of IterativeVertexFinder, seed finding and fitting, no track removal yet
- b9a54240 - added functionality to reassign tracks after first fit in vertex finder, added associated functions
- f0b43d53 - completed reassignTracksAfterFirstFit case
- 3f78733c - added function to remove compatible tracks and outliers at end of finder iteration
- cfb4b3aa - first working version of IterativeVertexFinder, split functionality in more...
- f3f49a0d - removed hard-coded billoir fitter from finder, store unique_ptr of IVertexFinder in config now
- fbb0b2f9 - bug fixed, use always last seed in collection for selecting compatible tracks
- 8a52aa2a - bugs fixed, set maxVertices to 50 and increment iterator when reassigning tracks
- 77d845cc - full IterativeVertexFinder unit test working now with random number of...
- d949f36d - remove unused variable
- 8db0b0df - fix format
- 458046d8 - bug fixed, use last seed in seed collection also for constraint fits
- 303df33a - change position component get methods in unit test
- 0d523a22 - fix format
- 201c025c - reduced number of test cases in iterative vertex finder test
- 63b09fcc - simplified LinTrackFactory argument in config
- 8c154d3c - adapt after rebase
- 04df0528 - clang tidy
- f7b6245f - bug fixed
- 2c19a2ed - move propagator from find function argument list to config
- 6a55a168 - move debug bool to cfg
- 7e9a61a9 - bug fix, fix format
- 7547a90c - added some documentation
- 8147a08e - fix format
- 2ed30e6d - added logging to IterativeVertexFinder and moved ZScanVertexFinder from...
- c974e89f - going back to flat directory hierachy
- 8991ee4a - added correct IVertexFitter version
- 3c180b16 - introduced geo and bfield context to vertex finder
- 56aa9cbb - added some documentation for ImpactPoint3dEstimator
- 76c7bec4 - added countSignificantTracks to IterativeVertexFinder and some documentation
- d2ad39d7 - remove camel case from template params
- 1e13543b - Use boost shared lib for all unit tests
- 4d4bb8b6 - add const keyword to find function
- d1aaba95 - format fix and FsmwMode1dFinder reference
- 314d40c5 - Apply suggestion to Core/include/Acts/Vertexing/IterativeVertexFinder.ipp
- f5940287 - Apply suggestion to Core/include/Acts/Vertexing/IterativeVertexFinder.ipp
- 91b48432 - Apply suggestion to Core/include/Acts/Vertexing/ZScanVertexFinder.ipp
- 4c4f923f - use fixed seed for unit tests
- 390ba0ff - docs update
- e08640df - more docs updates
- fcf52f5d - variable rename
- 22c59a97 - format
- d7046c20 - some minor changes
- 714039f7 - add error handling to all methods in IterativeVertexFinder
- 94ea6c8f - replace longish iterator type with auto
- ab512eee - update docs
- 34626045 - add some doc comments
- 95bab4fc - bug fix, set new tracksAtVertex after removing of outliers after fit and some minor changes
- 43e0c5b8 - algorithm description added to hpp
- bdc42c33 - Update IterativeVertexFinder.hpp
- 21c0536c - remove perigeeList filled in every iteration and use seedTracks instead directly
- 9614c2b8 - docs updated
- f32c3d0e - clang tidy
- 1cd427f4 - vertex annealing tool for MAVFitter started
- eacb110c - VertexAnnealingTool implemented with getWeight() methods
- 2a2462c3 - use std::exp instead of exp
- 04ecc5bc - add correct libraries
- 78b2c886 - added first VertexAnnealingTool unit tests
- 9dc94714 - unit test for VertexAnnealingTool for multi chi2 added
- fdc0ca3c - implementation of KalmanVertexTrackUpdator started
- 63633360 - format
- 24843dca - KalmanVertexUpdator added, KalmanVertexTrackUpdator implementation continued
- 578bbad2 - SequentialVertexSmoother with unit tests added
- 4adfd877 - license update
- 52333a50 - long long rebase...
Toggle commit list-
4275f382...c8199504 - 62 commits from branch
added 1 commit
- a3674126 - first version of Chi2TrackCompatibilityEstimator added
added 1 commit
- 69167b53 - added setTrackCompatibility method to Chi2TrackCompatibilityEstimator
added 1 commit
- d2bd5b91 - added some implementation for MVAF, not done yet...
added 1 commit
- bf4d8c20 - added isAlreadyInList method to MAVFitter and complete addVertexToFit method
added 109 commits
-
bf4d8c20...a47830c5 - 95 commits from branch
master - 3a1f63fc - FsmwMode1dFinder and TrackToVertexIPEstimator added
- 6a565d30 - vertexCompatibility added to trackAtVertex
- a53e01a1 - first version of Chi2TrackCompatibilityEstimator added
- 623d93ef - added setTrackCompatibility method to Chi2TrackCompatibilityEstimator
- 60336952 - defaulted config in VertexAnnealingTool
- c7993d31 - added vertex update and add methods to KalmanVertexUpdator, moved...
- 3b938b47 - added some implementation for MVAF, not done yet...
- ba15783b - docs for addVertexToFit method added
- a051cf4b - added MAVInfo file
- a77aacfa - added isAlreadyInList method to MAVFitter and complete addVertexToFit method
- c30a34da - update license
- 320cec5c - update input parameter names for MAVFitter method
- be2f8719 - format
- e347f6ec - adapt MAVF to 4D vertexing with time component after rebase
Toggle commit list-
bf4d8c20...a47830c5 - 95 commits from branch
Please register or sign in to reply