Skip to content

PlaneLayerTests-inspired bugfixes

Hadrien Benjamin Grasland requested to merge hgraslan/acts-core:more-verrou-testing into master

So, I was running the ACTS tests in Verrou and noticed that the PlaneLayerTests were manipulating NaNs for wrong reasons:

  • A number of tests attempted to create null transforms by running std::make_shared<const Transform3D>(), which actually creates an uninitialized transform instead.
  • SurfaceArrayCreator and LayerCreator exposed APIs for binning surfaces together with a default binning on the X axis. This was a bad default (as non-transformed surfaces are in the XY plane, Z-binning would be the best default choice), and the right answer is input-dependent, so I think having a default is a bad idea anyway.

Fixes #636 (closed) and #637 (closed) .

Edited by Hadrien Benjamin Grasland

Merge request reports