Use DDCore target directly (!798) · Merge requests · acts / acts-core · GitLab

Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

Merged Paul Gessinger requested to merge dd4hep_target into master 5 years ago

All threads resolved!

The DDCORE_LIBRARY variable seems not to be filled (I think starting from 1.11). This is more idiomatic in CMake anyway. Checks the DD4hep version to keep compatibility with old ones.

Edited 5 years ago by Paul Gessinger

Activity

Paul Gessinger changed milestone to %0.20.00 5 years ago

changed milestone to %0.20.00
Paul Gessinger added Improvement label 5 years ago

added Improvement label
Paul Gessinger marked as a Work In Progress 5 years ago

marked as a Work In Progress
Paul Gessinger changed the description 5 years ago

changed the description
Paul Gessinger added 1 commit 5 years ago
added 1 commit

df07df28 - fix for older versions of DD4hep

Compare with previous version
Paul Gessinger changed the description 5 years ago

changed the description
Paul Gessinger unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress
Moritz Kiehn @msmk started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Paul Gessinger
Last reply by Paul Gessinger 5 years ago

Moritz Kiehn @msmk started a thread on the diff 5 years ago

Resolved 5 years ago by Moritz Kiehn

Moritz Kiehn added 10 commits 5 years ago

added 10 commits

df07df28...7222b682 - 8 commits from branch master
bf3cd008 - Use DDCore target directly
1069b4a8 - fix for older versions of DD4hep

Compare with previous version

Paul Gessinger added 1 commit 5 years ago

added 1 commit

ffb457c4 - Update whitespacing

Compare with previous version

Paul Gessinger resolved all threads 5 years ago

resolved all threads

Moritz Kiehn approved this merge request 5 years ago

approved this merge request

Moritz Kiehn @msmk · 5 years ago

Contributor

Looks good. Thanks.

Moritz Kiehn enabled an automatic merge when the pipeline for succeeds 5 years ago

enabled an automatic merge when the pipeline for ffb457c4 succeeds

Moritz Kiehn mentioned in commit 5 years ago

mentioned in commit 2d0bef61

Moritz Kiehn merged 5 years ago

merged

Paul Gessinger mentioned in merge request atlas/atlasexternals!660 (merged) 4 years ago

mentioned in merge request atlas/atlasexternals!660 (merged)

Please register or sign in to reply