Stop running strings:validate:reference check
-
Review changes -
-
Download -
Patches
-
Plain diff
Up to now we have been running rake targets:
lint,
validate,
parallel_spec,
as of recently validate as sprung a new task
strings:validate:reference
this checks the REFERENCE.md
is updated from the puppet strings.
Take this out since we do not want to run it. Running validate
with trace is
currently:
** Invoke validate (first_time)
** Execute validate
** Invoke syntax (first_time)
** Invoke syntax:manifests (first_time)
** Execute syntax:manifests
---> syntax:manifests
** Invoke syntax:templates (first_time)
** Execute syntax:templates
---> syntax:templates
** Invoke syntax:hiera (first_time)
** Invoke syntax:hiera:yaml (first_time)
** Execute syntax:hiera:yaml
---> syntax:hiera:yaml
** Execute syntax:hiera
** Execute syntax
** Invoke metadata_lint (first_time)
** Execute metadata_lint
** Invoke strings:validate:reference (first_time)
** Execute strings:validate:reference
so we replace with syntax
, to achieve the same result
minus the strings check.
** Invoke syntax (first_time)
** Invoke syntax:manifests (first_time)
** Execute syntax:manifests
---> syntax:manifests
** Invoke syntax:templates (first_time)
** Execute syntax:templates
---> syntax:templates
** Invoke syntax:hiera (first_time)
** Invoke syntax:hiera:yaml (first_time)
** Execute syntax:hiera:yaml
---> syntax:hiera:yaml
** Execute syntax:hiera
** Execute syntax
Also it makes far more sense to run syntax
before lint
since no point linting bad syntax.
The metadata_lint
looks like it is being ran but in reality it is not since rubygem-metadata-lint-json is not installed.
If referenced directly them metadata_lint
task fails hard.
Contemplate metadata_lint
with migration to Alma 9 and newer ruby.
Edited by Steve Traylen
Merge request reports
Activity
Filter activity
- Approvals
- Assignees & reviewers
- Comments (from bots)
- Comments (from users)
- Commits & branches
- Edits
- Labels
- Lock status
- Mentions
- Merge request status
- Tracking
Please register or sign in to reply
Loading