Chad Stephen Lantz authored 1 year ago and Julien Maurer committed 1 year ago

Update of ZDC geometry using ZdcIdentifier ATLASSIM-6751

Adapt to interface changes of `StoredMaterialManager`.

Passing the `MessageSvc` pointer is no longer necessary for
`AthMessaging`.

Explicitly qualify virtual methods called from ctors.

Enable thread-safety checking.
Clean up warnings.

Updated ForwardDetectors packages to use FindGeoModel.cmake. Which was introduced
to serve the new GeoModel uni-project, which was introduced into our build with !39900.

Bonus:
 * Turned AFP_GeoModel and ZDC_GeoM into component-only packages
 * Turned ForwardRegionGeoModel into interface + component package

Dropped the redundant AbsMaterialManager interface, and removed all references to this
interface from client packages.

Dropped redundant methods from RDBMaterialManager, and in this way got rid of lots of
duplicated code.

If a dtor is declared final, the class itself should also be declared final.

All units migrated except GeoModelKernelUnits::gram/g, which is different from Gaudi::Units::gram/g

Given the standalone library is based on Eigen instead of CLHEP, all GeoModel clients
in Athena code were also migrated to the Eigen-based interface of GeoModel. This affected
a large number of packages. Most significant changes have been introduced to subsystem
GeoModel packages.

The in-house GeoModelKernel code has been removed from the repository.

Almost all header files in PixelGeoModel have been moved to the src directory.
The next step should be turning this package into a component-only library.
Similar code reorganization can be applied to SCT_GeoModel too.

Subsystem readout geometry interfaces remain mostly unchanged, except for a minor
change in the InDet readout geometry interface (which was unavoidable).

Several non-GeoModel packages affected by this migration mostly required addition
of missing CLHEP includes.


Former-commit-id: 9cffebb1

Deprecating use of non-bound DataHandle, especially non-const.
Also adding const for materials.


Former-commit-id: 662fd53d

Former-commit-id: 9b39c6d9

gcc8 warnings: catching polymorphic exceptions via value.


Former-commit-id: 08af9cc7

A few constructors had to be made public as required by the Gaudi Plugin
service.


Former-commit-id: b88be914d83755d32a130be4d36c218733be605b

- Delete all obsolete src/components/*_load.cxx files
- Remove obsolete DECLARE_FACTORY_ENTRIES within
  src/components/*_entries.cxx

The removed macros evaluate to NULL on the Gaudi side and have been
kept only for backwards compatibility.


Former-commit-id: b54b335b

Vakhtang Tsulaia authored 7 years ago and Adam Edward Barton committed 7 years ago

Former-commit-id: 237a8a9f

Private data members should start with m_.



Former-commit-id: b4989492

	* Migrating from endreq to endmsg
	* Tagging as ZDC_GeoM-00-00-13


Former-commit-id: 4c960a94