Shaun Roe authored 2 years ago and Edward Moyse committed 2 years ago

23.0-cppcheck-suppress-LWHists

Suppress some cppcheck warnings that were new with cppcheck 1.89.
Add some missing virtual/override keywords.

This should make the memory allocators used by LWHists thread-safe.
So it should be ok to concurrently manipulate distinct LWHist objects.
However, it is not safe to concurrenty modify the same LWHist object.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

LWHists: Use call_once instead of a static flag.

Moving to get this package to pass the thread-safety checker.

Disable thread-safety checking for top-level test code.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

LWHists: Get rid of global variables in test code.

Moving towards having this package pass the thread-safety checker.

Moving towards getting this package to pass thread-safety checks.

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

LWHists: More const-correctness fixes.

Moving towards getting this package to pass thread-safety checks.

Moving towards getting this package to pass thread-safety checks.

Introduce missing virtual/override keywords.

Moving towards getting this package to pass thread-safety checks.

Shaun Roe authored 2 years ago and Edward Moyse committed 2 years ago

23.0-cppcheck-LWHists

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

LWHists: Fix thread-safety checker warnings.

Fix some new thread-safety checker warnings.

Use atomic for histogram counter to avoid thread-checker warnings in
client code. In general, the `LWHists` are not thread-safe.

- add const-correct `getCustomData`
- `TProfile2D_LW`: use `std::as_const` for read-only hist access

Frank Winklmeier authored 3 years ago and Johannes Elmsheuser committed 3 years ago

Remove usage of obsolete `PACKAGE_VERSION` macro. Also cleanup
essentially empty methods.

Partially addresses ATEAM-677

Library dependency fixes.

If you do a SetBinError with an out-of-bounds bin, older versions of root
would still create the error array in the histogram.  LWHists had code
to emulate this behavior.  However, this changed as of root 6.18: if the 
bin is out of bounds, then the histogram is not changed.  Adapt the LWHist
code to match.

cppcheck warnings:
 - assert with side effects.
 - x!=x instead of isnan.
 - calling virtual function from destructor.
 - undefined/implmentation-defined bit shifting behavior.
 - passing std::string::c_str() to a std::string argument.
 

Fix path in CxxUtils dependency.


Former-commit-id: effe1779

Migrate ATN tests to ctest.
Also fix some ubsan failures observed in the tests.
Due to this, we now have a dependency on CxxUtils.

Former-commit-id: 30c68841

Former-commit-id: 9b39c6d9

gcc8 warning: Using memcopy instead of C++ copy operation.


Former-commit-id: ee66b70e

Remove cmt directories that contain trivial, obsolete content.


Former-commit-id: c24266ed

Former-commit-id: eac78a5ccbc62359fcdca875734d7b71ae6c1fb8

When running with the undefined behavior sanitizer, we get warnings
about unaligned accesses.  This is indeed undefined (and will lead
to silent runtime failures on some architectures).
Where it makes sense, add a little extra padding to get things
aligned.  Suppress other alignment warnings.



Former-commit-id: 69b8965c

Former-commit-id: 2155572e71e23eb2170e957d131516b51d038de6

Added README.


Former-commit-id: bd08d1dd

	* Fix failure in ATN test for gcc 6.2
	* Tag LWHists-00-06-24

2016-08-15  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-23.
	* src/tests/comphistfiles/comphistpars.h: Fix references to
	isnan.

2016-07-19  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-22.
	* CMakeLists.txt: Fix cmake build on centos7.

2016-06-30  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-21.
	* src/FlexProfileArray.icc (FlexProfileArray): Suppress cppcheck
	false positive.


Former-commit-id: d6b99eb2

	* Tagging LWHists-00-06-20.
	* src/FlexErrArray.h: Fix compilation with gcc6.


Former-commit-id: 2d133fbd

2016-05-17  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-19.
	* src/tests/comphistfiles/comphistpars.h: Fix typo (coverity
	30950).

2016-04-13  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-18.
	* Fix cppcheck warnings.

2016-02-27 Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
	* Adding a hand-written CMakeLists.txt file to the package,
	  in order to build its library and executables correctly.
	* Tagging as LWHists-00-06-17


Former-commit-id: 82012646

	* Tagging LWHists-00-06-16.
	* Avoid triggering integer overflow during tests.

2015-09-15  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-15.
	* cmt/requirements: Fix macro setting.
	* src/FlexBinChunk.icc, src/FlexErrArray.icc: Fix clang warnings.

2015-07-03  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-14.
	* src/tests/validation/main_validation.cxx: Another instance of
	a weighted fill of TProfile.

2015-07-01  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-13.
	* Some adaptations to changes in root that were leading to test
...
(Long ChangeLog diff - truncated)

	* Tagging LWHists-00-06-10.
	* replace Thomas Kittelmann's email with SRL

	* Tagging LWHists-00-06-09.
	* src/tests/comphistfiles/comphistpars.h: Need a TString overload
	for varCompatible.

2014-10-20  scott snyder  <snyder@bnl.gov>

	* Tagging LWHists-00-06-08.
	* Fix coverity warnings.

2014-07-16 David Quarrie <David.Quarrie@cern.ch>
	* cmt/requirements
		Add cmake compatibility (fully backwards compatible on CMT side)
	* Tagged as LWHists-00-06-07