DataQualityInterfaces, LArGeoEndcap, DumpEventDataToJSON, BeamPipeGeoModel cppcheck / clang-tidy fixes

Edward Moyse authored 3 years ago and Adam Edward Barton committed 3 years ago

For tracks, prefer parameters over measurements

Robert Johannes Langenberg authored 5 years ago and Edward Moyse committed 5 years ago

create Tracking/TrkConfig package, move all new configuration files in, update path where they were used

Updated `ComponentAccumulator` configuration tests which dump the configuration
to a pickle file. In python3 the output file needs to be explicitly opened in binary mode.
I.e. ```f = open('configdump.pkl','wb')```
rather than ```f = open('configdump.pkl','w')```

Enable the ATLAS-specific flake8 checks ("ATL") for packages that
already define a flake8 unit test. See

https://gitlab.cern.ch/atlas/atlasexternals/tree/master/External/flake8_atlas

for a list of the additional checks.

Edward Moyse authored 5 years ago and Frank Winklmeier committed 5 years ago

Test ID now, and also fix problem with some properties of Trk__TrackingGeometrySvc not being filled.

Flake8 failure.

Fixed missing installation of python files, extended and improved the test in the Config file, and also explicitly disable the extrapolator if not required, to avoid an unconfigured autoretrieve.

Fix warnings/errors flagged by `flake8`. Mostly unused variables/imports
or stylistic code problems.

Edward Moyse authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Fixes for extrapolation - you need to explicitly turn the correct geometry and detdescr on, because otherwise the tracking geometry is not built. And we cannot just turn everything on or forward detetctors fails.

Edward Moyse authored 5 years ago and Stewart Martin-Haugh committed 5 years ago

Initial commit of DumpEventDataToJSON, including Jets and TrackParticles, with some simple extrapolation.