Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

Muon geometry - Convert Micromegas from the R4 format into the legacy one

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelR4 - Convert new sTgc readout elements into their legacy version

Maximilian Emanuel Goblirsch-Kolb authored 10 months ago and Tadej Novak committed 10 months ago

Add phi extension to Phase-2 Muon pattern recognition and clean up / document existing steps

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonReadoutGeometryR4: Speed up MdtTubeLayer::getTubeNode().

This was using getChildVol.  However, that keeps track of the transform
to each child, even though that is not actually used.
This is slow, especially in debug builds where Eigen operations
tend to be expensive.

Instead, use GeoVisitVolumes to iterate over children without calculating
the transforms.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

MuonGeoModelTestR4: cmake fix

Missing find_package for ROOT.

Attila Krasznahorkay authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Made all binaries that depend on LTO, use LTO themselves as well.

Also, moved MuonSensitiveDetectorsR4 into AtlasGeant4.

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonGeoModelTestR4: Fix cppcheck warnings.

Use string::starts_with rather than string::find.

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonReadoutGeometryR4: Speed up handling of tube transforms.

Calling toTubeFrame is expensive, since it needs to walk over all children
until it gets to the desired value.  Hence, calling toTubeFrame from within
a loop over tubes is an N^2 operation.  Further, MdtReadoutElement::initElement()
was calling toTubeFrame multiple times for each tube.
This is especially painful in a debug build, where Eigen matrix operations
are very slow.

Speed up by using GeoVolumeCursor to change from the nested O(N^2) iteration
to a single O(N) iteration, and only evaluate the transform once per tube.

Also fix a logic error the prevented the layer-to-layer pitch test from
executing.

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Muon R4 - Add infrastructure to digitize BI-RPC hits

Paul Nathaniel Swallow authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Improving hashing for BIL with adding the zIndex and changing multidimensional array to a std_unordered map with some input from Johannes

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonR4 - Fix failing unit tests

Johannes Junggeburth authored 10 months ago and Johannes Elmsheuser committed 10 months ago

PrepData R4 - Add BI RpcStrip container class

Scott Snyder authored 10 months ago and Johannes Elmsheuser committed 10 months ago

MuonGeoModelTestR4: Fix placement of using directives.

Don't put using directives before #include.

Scott Snyder authored 10 months ago and Walter Lampl committed 10 months ago

MuonReadoutGeometryR4: Speed up tube layer sorting.

In the comparison function for MdtTubeLayer, don't bother calling the underlying
comparison functions if the objects being compared are identical.
GeoPhysValSorter, in particular, is expensive to call.
This speeds things up considerably, especially in the debug build.

Johannes Junggeburth authored 10 months ago and Frank Winklmeier committed 10 months ago

MuonR4 geometry - Fix crashes when running with multiple threads

Scott Snyder authored 10 months ago and Frank Winklmeier committed 10 months ago

MuonSpacePoint: Fix eigen alias problem.

Fix a problem with aliasing eigen objects.

Fixes test failure seen in MuonHitCsvDump in the debug build.

Dimitra Amperiadou authored 11 months ago and Adam Edward Barton committed 11 months ago

trapezoidal bounds for the chambers

Johannes Junggeburth authored 11 months ago and Adam Edward Barton committed 11 months ago

MuonSimHitConversion - Use central geometry context & don't fill the pos in station information

Johannes Junggeburth authored 11 months ago and Adam Edward Barton committed 11 months ago

MuonReadoutGeomtetryCnv - Add translation of Rpc detectors

Johannes Junggeburth authored 11 months ago and Adam Edward Barton committed 11 months ago

TransformCache remove lambda functions

Edward Moyse authored 11 months ago and Tadej Novak committed 11 months ago

Add xAOD PRDs to RPC convertor and add RPCs to test

Johannes Junggeburth authored 11 months ago and Tadej Novak committed 11 months ago

MuonSensitiveDetectorsR4 - Fetch the transforms from the per event scheduled GeometryContext

Johannes Junggeburth authored 11 months ago and Tadej Novak committed 11 months ago

AlignmentCondAlgs - Lock GeoAlignmentStores before writing to CondStore

Johannes Junggeburth authored 11 months ago and Vakhtang Tsulaia committed 11 months ago

ActsGeometryContext - Non const access

Johannes Junggeburth authored 11 months ago and Vakhtang Tsulaia committed 11 months ago

MuonSpacepointformation - Fix covariance & misc

Ishan Kiritbhai Vyas authored 11 months ago and Vakhtang Tsulaia committed 11 months ago

Fixing padCorner function, adding 1.5 to beamlineRadius temporarily until it is fixed, modifying globalChannelPosition function to be more efficient

Johannes Junggeburth authored 11 months ago and Vakhtang Tsulaia committed 11 months ago

Update 4 files

- /Tracking/Acts/ActsGeoUtils/src/SurfaceCache.cxx
- /Tracking/Acts/ActsGeometry/src/DetectorVolumeSvc.cxx
- /Tracking/Acts/ActsGeometry/ActsGeometry/DetectorVolumeSvc.h
- /Tracking/Acts/ActsGeometryInterfaces/ActsGeometryInterfaces/IDetectorVolumeSvc.h

Fix compilation with hepmc2.

Maximilian Emanuel Goblirsch-Kolb authored 11 months ago and Edward Moyse committed 11 months ago

refine Phase-2 eta hough transform

Ishan Kiritbhai Vyas authored 11 months ago and Edward Moyse committed 11 months ago

Fixing padCorner function, adding 1.5 to beamlineRadius temporarily until it is fixed, modifying globalChannelPosition function to be more efficient

Johannes Junggeburth authored 11 months ago and Edward Moyse committed 11 months ago

MuonChamberAssembleTool - Fix crash when geometry does not schedule Rpc

Maximilian Emanuel Goblirsch-Kolb authored 11 months ago and Edward Moyse committed 11 months ago

Add R4 version of MDT hough transform

Ishan Kiritbhai Vyas authored 11 months ago and Edward Moyse committed 11 months ago

Adding basic pad dimensions to geometry tool and readoutElement. temporarily using the wiredesignptr to build the pads. Changing wireGrouplayer active area dimensions to match the R3 implementation, using padWidth instead of stripWidth

Johannes Junggeburth authored 11 months ago and Frank Winklmeier committed 11 months ago

RpcReadoutElement - Initial clean-up of this beauty

1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variable

Johannes Junggeburth authored 1 year ago and Frank Winklmeier committed 1 year ago

MuonChamberAssembleTool -- Split BOL7 chambers from the generic BOL sector

Johannes Junggeburth authored 1 year ago and Frank Winklmeier committed 1 year ago

Fix Tgc stereo angle

Express the uncertainties w.r.t channel normals. Introduce Jacobian mechanism for 1D space points