John Derek Chapman authored 9 months ago and Frank Winklmeier committed 9 months ago

Introduce a common naming scheme for methods and variables related to primary GenParticles

John Derek Chapman authored 9 months ago and Frank Winklmeier committed 9 months ago

Beginning the process of documenting simulation classes

Thomas Strebler authored 9 months ago and Duc Ta committed 9 months ago

Added CA ZdcNtuple script

Johannes Junggeburth authored 10 months ago and Tadej Novak committed 10 months ago

Put GeoModel libs first in the Cmake lists

Revert align store

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

ZdcAnalysis: Fix cppcheck warnings.

Redundant string conversion.
Move some member initialization to an initialization list.

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

HepMcParticleLink constructor syntax clean-up.

Avoid using 0 in combination with HepMcParticleLink::IS_EVENTNUM in constructor calls as this is not properly supported.
It is more correct to directly use 0 with HepMcParticleLink::IS_POSITION to indicate that the link is to the first
GenEvent in the McEventCollection.

John Derek Chapman authored 10 months ago and Tadej Novak committed 10 months ago

Clean-up of ForwardTransport code

Joseph Boudreau authored 10 months ago and Tadej Novak committed 10 months ago

CMakeLists.txt files have been updated for all instances which depend
on the GeoModel core libraries but which do not explicitely include
${GEOMODEL_INCLUDE_DIRS}.  Without this we are in danger of mixing
header files from two sources, and this is actually now happening in
the GeoModel early fault detection pipeline.

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

ZdcRec: Fix cppcheck warnings.

Prefer passing strings by const reference.

Mason Ray Housenga authored 10 months ago and Duc Ta committed 10 months ago

ZDC: update RPD calibration procedure

Thomas Strebler authored 10 months ago and Ahmed Tarek committed 10 months ago

Clean up legacy ALFA_BeamTransport configs

Scott Snyder authored 10 months ago and Tadej Novak committed 10 months ago

ForwardTracker: Fix cppcheck 2.14 warnings.

Prefer returning const references to members rather than copies.
Pass object by const reference, not by value.

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

Mason Ray Housenga authored 10 months ago and Duc Ta committed 10 months ago

ZDC: fix for rare RPD linear algebra ROOT errors (ATLASRECTS-7967)

Mason Ray Housenga authored 10 months ago and Duc Ta committed 10 months ago

ZDC: change bool storage type to char

Attila Krasznahorkay authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Made all binaries that depend on LTO, use LTO themselves as well.

Also, moved MuonSensitiveDetectorsR4 into AtlasGeant4.

Vakhtang Tsulaia authored 10 months ago and Johannes Elmsheuser committed 10 months ago

Fixed clang warnings

Removed unused private data members. Plus minor code cleanup.
Affected packages
- `ForwardDetectors/ZDC/ZdcAnalysis`
- `LArCalorimeter/LArCOOLConditions`

Frank Winklmeier authored 10 months ago and Johannes Elmsheuser committed 10 months ago

CaloClusterCorrection+CaloCondPhysAlgs: fix flake8-bugbear warnings

Replace `getattr` with regular attribute access.

Brian Andrew Cole authored 10 months ago and Duc Ta committed 10 months ago

Push updates for 2016 pPb and 2023 PbPb into fresh branch

Benjamin Morgan authored 10 months ago and Walter Lampl committed 10 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

Replace auxdata, etc. with Accessor classes.
Moving to deprecate these usages in the Athena build.

This reverts commit 9b36ad1f, reversing
changes made to 4d2926b2.

Benjamin Morgan authored 10 months ago and Duc Ta committed 10 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

Andrii Verbytskyi authored 10 months ago and Frank Winklmeier committed 10 months ago

Fix cppcheck warnings

Scott Snyder authored 10 months ago and Frank Winklmeier committed 10 months ago

AFP_Calibration: Fix cppcheck warning.

Copying value in range-for.

Scott Snyder authored 10 months ago and Frank Winklmeier committed 10 months ago

ZdcNtuple: Fix compilation with hepmc2.

Hepmc2 compatibility.

John Derek Chapman authored 10 months ago and Frank Winklmeier committed 10 months ago

Update TruthIncidents and ISFParticle to know about uniqueID

Frank Winklmeier authored 10 months ago and Ahmed Tarek committed 10 months ago

ZdcByteStream: remove legacy job options

Thomas Strebler authored 11 months ago and Ahmed Tarek committed 11 months ago

Clean up more AFP legacy configs