Benjamin Morgan authored 10 months ago and Walter Lampl committed 10 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

This reverts commit 9b36ad1f, reversing
changes made to 4d2926b2.

Benjamin Morgan authored 10 months ago and Duc Ta committed 10 months ago

Add CMake option to enable LTO for AtlasGeant4

Use of LTO in Athena builds is not currently possible if the GCC checker
plugins are in use. These are not yet LTO-aware, leading to build
errors. Disabling these globally or per-LTO-using-package is not
feasible as it could lead to the introduction of bad code.

Whilst the plugins are made LTO-aware, introduce CMake option in Athena
and AthSimulation for enabling LTO builds of the AtlasGeant4 "big"
library. Set to OFF by default so that "normal" builds are unaffected.
Builds wanting LTO can set the option to ON, but must also set
ATLAS_USE_GCC_CHECKERS to OFF in this case.

Thomas Strebler authored 11 months ago and Ahmed Tarek committed 11 months ago

Clean up legacy TBCaloGeometry config

Delete legacy config and only build a component library.

Walter Lampl authored 1 year ago and Ahmed Tarek committed 1 year ago

Delete a number of obsolete Calo-Geometry config files

Uninitialized variables.

Scott Snyder authored 1 year ago and Tadej Novak committed 1 year ago

TBDetDescrAlg: Deprecated SG methods.

createProxy -> recordAddress.

remove unused 'operator std::string()' methods from LArRawEvent

Andrii Verbytskyi authored 1 year ago and Julien Maurer committed 1 year ago

Remove the unused boost subpackages from find_package(), add missing

John Derek Chapman authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

ComponentAccumulator-based configuration of Tile Test Beam Simulation

Mark TBCalo[Cool]PosTool as not thread-safe (used of callbacks).

Closes ATLASRECTS-7346.

Christos Anastopoulos authored 2 years ago and Adam Edward Barton committed 2 years ago

IExtrapolator: Rename methods as to be more obvious what they do

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

TBEvent: Fix cppheck warnings.

Pass strings by const reference, not by value.

Christos Anastopoulos authored 2 years ago and Walter Lampl committed 2 years ago

IExtrapolator: Remove Particle interfaces

Unused variables.

Walter Lampl authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

Make CaloRec a pure component library

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TBDetDescrCnv: Enable thread-safety checking.

Enable thread-safety checking.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TBTPCnv: Enable thread-safety checker.

Enable thread-safety checker and fix warnings.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TBCaloConditions: Remove EventInfo depedency.

Remove dependency on old EventInfo class.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TBCondRunPar: Remove reference to EventInfo.

Remove reference to old EventInfo class.

Scott Snyder authored 2 years ago and Frank Winklmeier committed 2 years ago

TBRec: Remove dependency on EventInfo.

Remove dependency on old EventInfo class.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

TBRec: Fix a const-correctness violation.
    
Should only get const pointers from a const AthenaHitsVector.

The `eformat_write` dependency is not needed as the bytestream
converters do not actually create the "writable" fragment. This is taken
care of by the ByteStreamCnvSvcBase.

Delete ancient code to monitor (pre Run-1) testbeam data.

Benjamin Morgan authored 2 years ago and Vakhtang Tsulaia committed 2 years ago

ATLASSIM-3150: Enable use of static Geant4 in Athena using "BigLibrary" pattern to improve simulation performance

Scott Snyder authored 2 years ago and Johannes Elmsheuser committed 2 years ago

TrkDetDescrAthenaPool+TBDetDescrAlg+TBDetDescrAthenaPool+MuonRPC_Cabling+MuonCablingServers: Enable thread-safety checking.

It is a widespread and reasonable, but incorrect, pattern to assume that if a handle(key) is not used then it should not be initialized.
In fact, this leaves the data dependency active in the scheduler, and no error will be thrown if the handle is never accessed.
Instead, the handle should be initialized(false) - this MR makes the change

Explicitly qualify virtual methods called from ctors.

    
Uninitialized pointer passed to SG::retrieve.