Skip to content

Bring unpacker even with v302a and use standard mapping formats

Antonello Pellecchia requested to merge bugfix/fed-id into main

Changes needed for better operations of QC8 and test beam setups:

  • parse FED ID from raw AMCEvent data;
  • use FED in mapping file (this breaks compatibility with GEM setups using fomat previous to v302a and requires to update mappings in all GEM setups. Only mappings in ME0 stack (both 3 and 4 layers) and QC8 have been fixed, while pre-2023 setups (i.e. hybrid FW test beams) remain supported only by legacy code for now);
  • improve unpacker printing, both for the raw event and for the Digi event;
  • remove old options (e.g. isFedKit variable) and fix bugs with v302a compatibility (e.g. the orbit counter size is brought from 16 to 32 bits);
  • the mappings are restructured using more consistent conventions (e.g. always vfat instead of vfatId), fixing bugs (e.g. with smart pointers) and going towards better consistency between VFAT and APV setups (e.g. using std::map in mapping classes, introducing a Mapping base class, start improving the folder structure), although some parts remain hardcoded in the unpacker and will be addressed in a later MR.
Edited by Antonello Pellecchia

Merge request reports