weird type check in PlottingFunctions.py
there is a weird type check in PlottingFunctions.py
elif type(binning[variable]) is None:
nBins_dict.update({variable: int(100)})
not sure what this should actually do? - I guess it should be rather
elif binning[variable] is None:
nBins_dict.update({variable: int(100)})
though then the unit test fail (but should be the wanted behaviour)
output from pylint
umami/input_vars_tools/PlottingFunctions.py:487:13: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
umami/input_vars_tools/PlottingFunctions.py:932:13: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
umami/input_vars_tools/PlottingFunctions.py:1259:13: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
umami/input_vars_tools/PlottingFunctions.py:1512:13: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
let's check this with @alfroch after the Christmas break