Add deprecation warning for old plotting kwargs
Update:
Old keyword arguments are currently translated by the translate_kwargs
function which is located in umami/plotting/utils.py
.
This function covers all cases (i.e. input var plots, evaluation plots, ...)
We will slowly move to new naming conventions (compatible with PEP-recommendations), but the old names will be supported for some time to maintain backwards compatibility.
At some point, when everything is moved to the new plotting python API, we can add a deprecation warning, that users should switch to the new conventions.
Even later, we might stop supporting the old naming, by just removing the translate_kwargs
function / making it raise an error if old variables are used.
Initial discussion:
The following discussion from !434 (merged) should be addressed:
-
@birk started a discussion: (+1 comment) Maybe add a warning here such that at some point in the future we can get rid of these or do you think this will stay for backwards compatibility?
Wait with that until we switched completely to the new API. (#147 (closed) and maybe even more)