Skip to content
Snippets Groups Projects
Alexander Froch's avatar
commented on merge request !832 "Draft: Adding trigger chains & EventSelection clean up" at atlas-flavor-tagging-tools / training-dataset-dumper

Changed them back to single quotation marks

Dan Guest's avatar
commented on merge request !832 "Draft: Adding trigger chains & EventSelection clean up" at atlas-flavor-tagging-tools / training-dataset-dumper

There is no standard. Can you disable your formatter? It's adding way too much noise: I didn't comment on the changes to imports but that's also a ...

Alexander Froch's avatar
commented on merge request !832 "Draft: Adding trigger chains & EventSelection clean up" at atlas-flavor-tagging-tools / training-dataset-dumper

Sorry for that, but it's I think "standard" to go with the double quotation marks. My formatter changes these automatically

Dan Guest's avatar
commented on merge request !832 "Draft: Adding trigger chains & EventSelection clean up" at atlas-flavor-tagging-tools / training-dataset-dumper

do you really need to change all the quotes from ' to "? This makes for a lot of noise.

Alexander Froch's avatar
opened merge request !832 "Draft: Adding trigger chains & EventSelection clean up" at atlas-flavor-tagging-tools / training-dataset-dumper
Alexander Froch's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

Added

Wei Sheng Lai's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

Didn't want to open a new MR but could you also change this to the ghost label HadronGhostTruthLabelID

Alexander Froch's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

This one should be there, but I rearranged a bit the order to make it more visible

Alexander Froch's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

Removed it

Alexander Froch's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

Removed it

Samuel Van Stroud's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

There should also be a pu score which is the sum of ud+s+g, which would be nice to save for convenience

Samuel Van Stroud's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

let's remove the detailed light jet class for the non PFlowMuon trainings? it's quite a lot of variables which will make working with the jets data...

Samuel Van Stroud's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

let's remove the pT regression for the simple flip taggers

Dan Guest's avatar
commented on merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper

I'm wondering if, just in case someone wants to create some samples now, we should hold off on this MR until the samples have finished.

Dan Guest's avatar
approved merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper
Alexander Froch's avatar
opened merge request !831 "Draft: Adding new FTAG1 p6698 Samples" at atlas-flavor-tagging-tools / training-dataset-dumper
Nikita Ivvan Pond's avatar
commented on merge request !828 "add a new config file to save gn2 flip outputs and mSV" at atlas-flavor-tagging-tools / training-dataset-dumper

If this whole config is the same as the GN3 config then instead this can be done like...

Dan Guest's avatar
accepted merge request !830 "Adding isHadronicTauFromTruthTaus Label" at atlas-flavor-tagging-tools / training-dataset-dumper
Dan Guest's avatar
  • ab05a574 · Adding isHadronicTauFromTruthTaus Label
Dan Guest's avatar
commented on merge request !830 "Adding isHadronicTauFromTruthTaus Label" at atlas-flavor-tagging-tools / training-dataset-dumper