Fix failing setup_athena pipeline and job dependency logic that was broken in previous commit

Description of bug

• setup_athena job was failing after changes in !2153 (closed) see #192 (closed)
• after the introduction of the rules keyword in !2153 (closed) all jobs after setup stage were always run independently of whether previous jobs failed

Changes introduced

• remove unnecessary changes from generateYaml.py to solve failing job
• switch when:always to when:on_success for all CI jobs after setup stage to keep dependency

Tests

See pipeline history in this MR - things look ok to me

Issues resolved

Closes #192 (closed)