Skip to content

Fix double booking of DSIDs when MG and aMC jO are committed together

Spyros Argyropoulos requested to merge fixJOAssignment into master

Description of bug

When MG and aMC (or Py8 and P8B) jO would be added in the same commit the script would treat them as two different generators because of https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/scripts/check_jo_consistency_main.py#L34 and https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/blob/master/scripts/jo_utils.py#L12

Changes introduced

Force the script to consider aMC and P8B the same generators (when assigning the DSID ranges) as MG and Py8 respectively.

Tests

Before fix

Screenshot_2023-09-15_at_18.56.09

After fix

Screenshot_2023-09-15_at_18.56.38
Screenshot_2023-09-15_at_18.57.19

The range of assigned DSIDs changes because there are only 2 free DSIDs 524546 and 524547 while in principle we would want to book 4 consecutive ones.

Issues resolved

Closes #214 (closed)

Edited by Spyros Argyropoulos

Merge request reports