Skip to content

Few fixes for logParser

Spyros Argyropoulos requested to merge fixlogParser into master

Bug description

  1. logParser crashing when comment was given after evgenConfig.nEventsPerJob
  2. logParser incorrectly printing a warning if CPU time between 1-8h and nEventsPerJob=10000
  3. no check to make sure that actual number of events to be produced are among nEventsAllowedInProduction - this check was only done for CountHepMC, so if someone would run with 10k events but then change evgenConfig.nEventsPerJob=40000 in the jO file logParser would incorrectly succeed

Changes introduced

  1. When reading nEventsPerJob from jO file do line.split('=')[1].split('#')[0].strip()
  2. the 2nd bug is fixed by this replacement
    Screenshot_2020-03-30_at_13.34.26
  3. The 3rd bug is fixed by Screenshot_2020-03-30_at_13.36.17

Tests

Log files taken from ATLMCPROD-8408

Bug 1

Before fix:
Screenshot_2020-03-30_at_13.37.43
After fix it finds the correct number of events

Bug 2

Before fix:
Screenshot_2020-03-30_at_13.39.14
After fix:
Screenshot_2020-03-30_at_13.39.58

Also if we would set evgenConfig.nEventsPerJob=5000 we get an ERROR as expected Screenshot_2020-03-30_at_13.40.56

Bug 3

Before fix:
Screenshot_2020-03-30_at_13.44.13
After fix:
Screenshot_2020-03-30_at_13.44.42

Issues resolved

Closes #

Edited by Spyros Argyropoulos

Merge request reports