Skip to content
Snippets Groups Projects

Adding bundled R(k*) real backgrounds

Merged Dominic Jones requested to merge dsid_dojones_802603 into master

Make sure that all the items in the checklists are duly followed:
follow the instructions of each checklist item and report potential issues to the repository mainteners.

JIRA ticket

ATLMCPROD-11614

Checklist for approval

This checklist should be normally filled by MC contacts (but it can also be done by the person opening the merge request).
If something is unclear get in touch with the repository maintainers.

  • I have followed the guidelines in McSampleRequestProcedure
  • I have provided the ATLMCPROD JIRA ticket where the request has been discussed
  • The request has been approved by the PA/CP group
  • The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers)
  • If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers
  • CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging)
  • Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed.
  • Check that the title of the MR is descriptive enough (if not ask the requester to modify it)
  • Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block
  • Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers.
Edited by Dominic Jones

Merge request reports

Merge request pipeline #9616925 passed

Merge request pipeline passed for 969e2c68

Approved by

Merged by Dominic JonesDominic Jones 2 months ago (Dec 16, 2024 11:35am UTC)

Merge details

  • Changes merged into master with 3144735e (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • **** added 1 commit

    added 1 commit

    Compare with previous version

  • Dominic Jones marked the checklist item I have followed the guidelines in McSampleRequestProcedure as completed

    marked the checklist item I have followed the guidelines in McSampleRequestProcedure as completed

  • Dominic Jones marked the checklist item I have provided the ATLMCPROD JIRA ticket where the request has been discussed as completed

    marked the checklist item I have provided the ATLMCPROD JIRA ticket where the request has been discussed as completed

  • Dominic Jones marked the checklist item The request has been approved by the PA/CP group as completed

    marked the checklist item The request has been approved by the PA/CP group as completed

  • Dominic Jones marked the checklist item The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers) as completed

    marked the checklist item The pipeline has run and the status is green (still check the CI job output - if you see any errors report to the repository maintainers) as completed

  • Dominic Jones marked the checklist item If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers as completed

    marked the checklist item If the pipeline is orange: check the CI job output to sort out the issues. If the issue is unclear contact the repository maintainers as completed

  • Dominic Jones marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

    marked the checklist item CI jobs have not been skipped (if jobs have been skipped, the requesters should provide a reason for skipping and confirmation from the PMG conveners is necessary before merging) as completed

  • Dominic Jones marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

    marked the checklist item Check that no log.generate.short files are included in the commit to be merged to master. If such files are present, it indicates that something went wrong in the pipeline. Check the job logs and contact the package maintainers if needed. as completed

  • Dominic Jones marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

    marked the checklist item Check that the title of the MR is descriptive enough (if not ask the requester to modify it) as completed

  • Dominic Jones marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

    marked the checklist item Check that the DSID range assigned is correct (500000-999999) and corresponds to right generator block as completed

  • Dominic Jones marked the checklist item Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers. as completed

    marked the checklist item Check that the ATLMCPROD link provided in "JIRA ticket" field above works and that a working link pointing to this MR is posted on the corresponding JIRA page. If not contact the package maintainers. as completed

  • Dominic Jones approved this merge request

    approved this merge request

Please register or sign in to reply
Loading