Extract nEventsPerJob as in ProdSys and move minevents check to check_jo_consistency
Changes introduced
- Use code from ProdSys to extract nEventsPerJob from file (!580 (merged))
-
logParser
extractsnEventsPerJob
using thejo_utils.py
script which mimics what's done in ProdSys - The check for
evgenConfig.minevents
has been moved fromlogParser
tocheck_jo_consistency
which is always run. This is done because ProdSys will first checkminevents
and only then checknEventsPerJob
, so a file that containsminevents
which was not tested (run with Gen_tf) locally or in the CI, might end up in the production system with the wrong settings.
Tests
minevents
is found in jO
ERROR when https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/9302962
logParser
correctly extracts nEventsPerJob
from log.generate
Complete pipeline here: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/pipelines/1806615
run_athena.sh
runs with correct number of events
Successful pipeline here: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/9303042
Todos
-
Re-introduce ERROR when minEvents
is used -
Test logParser -
Test athena
Issues resolved
Closes #98 (closed)
Edited by Spyros Argyropoulos