Skip to content
Snippets Groups Projects

Move athena skipping for external LHE fils from commit script to CI job

Merged Spyros Argyropoulos requested to merge fixlhe into master

Changes introduced

Currently the Gen_tf run in the run_athena CI job is being skipped automatically by the commit script which **deletes log.generate.short`, so it is unclear for the approvers whether something went wrong or not.

The skipping will now be done in run_athena. If it finds inputGeneratorFile in the log it will print a WARNING that the CI cannot yet handle it and will not run Gen_tf.

Tests

TBD

Issues resolved

Closes #

@cbecot @joany if there is a request with external LHE files ping me so that I can test what happens

Edited by Spyros Argyropoulos

Merge request reports

Pipeline #1842595 passed

Pipeline passed for e5605080 on fixlhe

Approved by

Merged by Christian GutschowChristian Gutschow 4 years ago (Aug 3, 2020 8:21am UTC)

Merge details

  • Changes merged into master with e5605080 (commits were squashed).
  • Deleted the source branch.

Pipeline #1842619 passed

Pipeline passed for e5605080 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading