Implement checks for inputfilecheck and inputGeneratorFile
Changes introduced
- Add check that no
evgenConfig.inputfilecheck
is present in jo - Add check that no
runArgs.inputGeneratorFile
is present in jo - Do not force
jo_utils
to return int
Tests
With a problematic file:
python scripts/check_jo_consistency_main.py 999xxx/999999/mc.PhPy8EG_NNPDF30LO_EWK_ZZeeee_valid.py
===> Checking jobOption consistency...
Modified jO file: 999xxx/999999/mc.PhPy8EG_NNPDF30LO_EWK_ZZeeee_valid.py - jO file = mc.PhPy8EG_NNPDF30LO_EWK_ZZeeee_valid.py
OK: New jobOption file
OK: name format correct
OK: PhPy8EG_NNPDF30LO_EWK_ZZeeee_valid physicsShort less than 50 characters long
OK: 2 physicsShort parts found
OK: Loading generator list file from /Users/sargyrop/Desktop/mcjoboptions/scripts/../common/GeneratorList.txt
OK: No generator full name is found
Generators used: ['Ph', 'Py8', 'EG']
OK: file does not contain includes pointing to MC15JobOptions
OK: file in unix format
OK: evgenConfig.minevents not found
ERROR: file /Users/sargyrop/Desktop/mcjoboptions/scripts/../999xxx/999999/mc.PhPy8EG_NNPDF30LO_EWK_ZZeeee_valid.py contains evgenConfig.inputfilecheck. You should remove this.
ERROR: file /Users/sargyrop/Desktop/mcjoboptions/scripts/../999xxx/999999/mc.PhPy8EG_NNPDF30LO_EWK_ZZeeee_valid.py contains runArgs.inputGeneratorFile. You should remove this.
OK: correct DSID range
OK: 999999 not used by other branches
===> Errors found - check output of individual checks above
The check in CI is here: https://gitlab.cern.ch/atlas-physics/pmg/mcjoboptions/-/jobs/9466120
Issues resolved
Closes #118 (closed)
Edited by Spyros Argyropoulos