Merge branch 'cppcheck.VP1UtilsBase-20210819' into 'master'

VP1UtilsBase: Fix cppcheck warnings.

See merge request !45943

graphics/VP1/VP1UtilsBase/VP1UtilsBase/VP1BatchUtilities.h

 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 /////////////////////////////////////////////////////////////
@@ -30,7 +30,7 @@ public:
 	std::string getRandomConfigFile();
 
 	static void overlayATLASlogo();
-	static void overlayEventDetails(unsigned long runNumber, unsigned long eventNumber, std::string humanTimestamp);
+	static void overlayEventDetails(unsigned long runNumber, unsigned long eventNumber, const std::string& humanTimestamp);
 
 private:
 	std::vector<std::string> m_files;

graphics/VP1/VP1UtilsBase/VP1UtilsBase/VP1FileUtilities.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 /////////////////////////////////////////////////////////////
@@ -51,7 +51,7 @@ public:
 		      int runNumber,
 		      int eventNumber,
 		      int timeStamp,
-              std::string textLabel = "");
+                      const std::string& textLabel = "");
 
   // **** Check if file exists ****
   static bool fileExistsAndReadable(const std::string&);

graphics/VP1/VP1UtilsBase/src/VP1BatchUtilities.cxx

 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 /////////////////////////////////////////////////////////////
@@ -24,9 +24,11 @@
 
 
 
-VP1BatchUtilities::VP1BatchUtilities(std::vector<std::string> files) : m_indexFile(0), m_lastIndexFile(0)
+VP1BatchUtilities::VP1BatchUtilities(std::vector<std::string> files) :
+  m_files(files),
+  m_indexFile(0),
+  m_lastIndexFile(0)
 {
-	m_files = files;
 	std::cout << "Got vector of " << files.size() << " items" << std::endl;
 	// Iterate and print values of vector
 	for(std::string n : m_files) {
@@ -90,7 +92,7 @@ void VP1BatchUtilities::overlayATLASlogo()
 
 // Overlay the event details to the image
 // it replaces the original image with a version having event details on it
-void VP1BatchUtilities::overlayEventDetails(unsigned long runNumber, unsigned long eventNumber, std::string humanTimestamp)
+void VP1BatchUtilities::overlayEventDetails(unsigned long runNumber, unsigned long eventNumber, const std::string& humanTimestamp)
 {
 
 	std::string nRun = std::to_string(runNumber);

graphics/VP1/VP1UtilsBase/src/VP1FileUtilities.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 /////////////////////////////////////////////////////////////
@@ -68,7 +68,7 @@ void VP1FileUtilities::produceNewFile(const std::string& sourceFile,
 				      int runNumber,
 				      int eventNumber,
 				      int timeStamp,
-                      std::string textLabel)
+                                      const std::string& textLabel)
 {
   // Check if the sourceFile exists
   QString srcName(sourceFile.c_str());