main-coverity-FPGATrackSimHough

main-coverity-FPGATrackSimHough

Trigger/EFTracking/EFTrackingFPGAIntegration/src/OutputConversionTool.cxx

-/**
+/*
+ *   Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
+ */
+ 
+ /**
  * @file src/OutputConversionTool.cxx
  * @author zhaoyuan.cui@cern.ch
  */
@@ -272,7 +276,7 @@ StatusCode OutputConversionTool::decodeFPGAoutput(const std::vector<uint64_t> &b
         {
             strip_edm_words.push_back(word);
             // Read in 9 consecutive words
-            if (strip_edm_words.size() == 9)
+            if (strip_edm_words.size() == 9 and scAux)
             {
                 scAux->idHash.push_back(get_bitfields_EDM_STRIPCLUSTER_w1(strip_edm_words[0]).id_hash);
                 scAux->id.push_back(get_bitfields_EDM_STRIPCLUSTER_w2(strip_edm_words[1]).identifier);

Trigger/EFTracking/FPGATrackSim/FPGATrackSimAlgorithms/src/FPGATrackSimNNPathfinderExtensionTool.cxx

@@ -8,12 +8,10 @@
  * @brief Default track extension algorithm to produce "second stage" roads.
  * Much of this code originally written by Alec, ported/adapted to FPGATrackSim.
  */
-
-#include "FPGATrackSimObjects/FPGATrackSimTypes.h"
-#include "FPGATrackSimObjects/FPGATrackSimHit.h"
+#include "FPGATrackSimAlgorithms/FPGATrackSimNNPathfinderExtensionTool.h"
 #include "FPGATrackSimBanks/FPGATrackSimSectorBank.h"
 
-#include "FPGATrackSimAlgorithms/FPGATrackSimNNPathfinderExtensionTool.h"
+
 #include "FPGATrackSimHough/FPGATrackSimHoughFunctions.h"
 
 #include <cmath>
@@ -438,7 +436,7 @@ StatusCode FPGATrackSimNNPathfinderExtensionTool::extendTracks(const std::vector
                 }
                 else
                 {
-                    cleanHitsToGrow = listofHitsFound;
+                    cleanHitsToGrow = std::move(listofHitsFound);
                 }
 
 

Trigger/EFTracking/FPGATrackSim/FPGATrackSimHough/src/FPGATrackSimHoughRootOutputTool.cxx

 /*
-  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2025 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FPGATrackSimHough/FPGATrackSimHoughRootOutputTool.h"
@@ -357,7 +357,7 @@ StatusCode FPGATrackSimHoughRootOutputTool::fillTree(const std::vector<FPGATrack
 
 
   // now do the same for offline tree, once per event
-  for (auto track : offlineTracks) {
+  for (const auto & track : offlineTracks) {
     if (!m_EvtSel->passCuts(track)) continue;
 
     m_offline_d0.push_back(track.getD0());