Merge branch 'cppcheck.TrigEgammaMatchingTool-20240523' into 'main'

TrigEgammaMatchingTool+TrigAFPHypo: Fix cppcheck warnings.

See merge request !71657

Trigger/TrigAnalysis/TrigEgammaMatchingTool/Root/TrigEgammaMatchingToolMT.cxx

 /*
-  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -64,7 +64,7 @@ StatusCode TrigEgammaMatchingToolMT::initialize()
 
 //!=======================================================================
 
-std::string TrigEgammaMatchingToolMT::key( std::string key) const
+std::string TrigEgammaMatchingToolMT::key( const std::string& key) const
 {
   return m_keys.at(key); 
 }

Trigger/TrigAnalysis/TrigEgammaMatchingTool/TrigEgammaMatchingTool/TrigEgammaMatchingToolMT.h

@@ -64,7 +64,7 @@ class TrigEgammaMatchingToolMT : public asg::AsgTool
         // access the feature from the container
         const xAOD::TrigRingerRings* getRingsFeature( const TrigCompositeUtils::Decision * ) const;
         // get the container key
-        std::string key( std::string ) const;
+        std::string key( const std::string& ) const;
 
     private:
         

Trigger/TrigHypothesis/TrigAFPHypo/src/TrigAFPToFHypoTool.h

 
 /*
-Copyright! (C) 2002-2012 CERN for the benefit of the ATLAS collaboration
+Copyright! (C) 2002-2012, 2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef TRIGAFPHYPO_TRIGAFPTOFHYPOTOOL_H
@@ -25,7 +25,7 @@ class TrigAFPToFHypoTool : public AthAlgTool
   
   struct AFPToFHypoToolInfo // data structure to be passed to the hypo tool
   {  
-   AFPToFHypoToolInfo(const TrigCompositeUtils::DecisionIDContainer a, const xAOD::AFPVertex* b, const xAOD::Vertex* c, TrigCompositeUtils::Decision *d) :
+   AFPToFHypoToolInfo(const TrigCompositeUtils::DecisionIDContainer& a, const xAOD::AFPVertex* b, const xAOD::Vertex* c, TrigCompositeUtils::Decision *d) :
    inputPassingChains(a), afpVtx(b), idVtx(c), outputDecision(d)
    {}
    const TrigCompositeUtils::DecisionIDContainer inputPassingChains;