From 43dc25a74a2c84e3300e4f3d117be999a5de2e71 Mon Sep 17 00:00:00 2001
From: Mark Stockton <mark.stockton@cern.ch>
Date: Thu, 26 Oct 2023 20:43:05 +0200
Subject: [PATCH] NewJO tests - add CA count comparison to dev and add PhysP1
 test

NewJO tests - add CA count comparison to dev and add PhysP1 test
---
 .../test/test_trigP1_v1Dev_newJO_build.py     | 10 ++++++++
 .../test/test_trigP1_v1PhysP1_newJO_build.py  | 24 +++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100755 Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_newJO_build.py

diff --git a/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_build.py b/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_build.py
index b2b1b4a75434..dce4e54a699c 100755
--- a/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_build.py
+++ b/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_build.py
@@ -12,6 +12,7 @@ ex = ExecStep.ExecStep()
 ex.type = 'athenaHLT'
 ex.job_options = 'TriggerJobOpts.runHLT'
 ex.input = 'data'
+ex.max_events = 50
 ex.flags = ['Trigger.triggerMenuSetup="Dev_pp_run3_v1_TriggerValidation_prescale"',
             'Trigger.doLVL1=True']
 
@@ -20,5 +21,14 @@ test.art_type = 'build'
 test.exec_steps = [ex]
 test.check_steps = CheckSteps.default_check_steps(test)
 
+# Add a step comparing counts against legacy reference (from test_trigP1_v1Dev_decodeBS_build)
+chaindump = test.get_step("ChainDump")
+chaindump.args = '--json --yaml ref_v1Dev_decodeBS_build.new'
+refcomp = CheckSteps.ChainCompStep("CountRefComp")
+refcomp.input_file = 'ref_v1Dev_decodeBS_build.new'
+refcomp.reference_from_release = True # installed from TrigP1Test/share
+refcomp.required = False # Final exit code doesn't depend on this step
+CheckSteps.add_step_after_type(test.check_steps, CheckSteps.ChainDumpStep, refcomp)
+
 import sys
 sys.exit(test.run())
diff --git a/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_newJO_build.py b/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_newJO_build.py
new file mode 100755
index 000000000000..843245df5bc9
--- /dev/null
+++ b/Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1PhysP1_newJO_build.py
@@ -0,0 +1,24 @@
+#!/usr/bin/env python
+# Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+
+# art-description: athenaHLT test of the PhysicsP1_pp_run3_v1 menu
+# art-type: build                                                                  
+# art-include: main/Athena
+# art-include: 23.0/Athena                                                       
+
+from TrigValTools.TrigValSteering import Test, ExecStep, CheckSteps
+
+ex = ExecStep.ExecStep()
+ex.type = 'athenaHLT'
+ex.job_options = 'TriggerJobOpts.runHLT'
+ex.input = 'data'
+ex.flags = ['Trigger.triggerMenuSetup="PhysicsP1_pp_run3_v1_HLTReprocessing_prescale"',
+            'Trigger.doLVL1=True']
+
+test = Test.Test()
+test.art_type = 'build'
+test.exec_steps = [ex]
+test.check_steps = CheckSteps.default_check_steps(test)
+
+import sys
+sys.exit(test.run())
-- 
GitLab