'Fix coverity warnings 108528, 108527, 108525, 108557, 108523 (uninitialized...

'Fix coverity warnings 108528, 108527, 108525, 108557, 108523 (uninitialized members).' (CaloUtils-01-00-59)

        * Tagging CaloUtils-01-00-59.
	* Fix coverity warnings 108528, 108527, 108525, 108557, 108523
	(uninitialized members).


Former-commit-id: 4b8cc93a

Calorimeter/CaloUtils/CaloUtils/CaloTopoTowerBuilderToolBase.h

@@ -63,11 +63,9 @@ class CaloTopoTowerBuilderToolBase : public AthAlgTool,
   // Store and Services //
   ////////////////////////
 
-  StoreGateSvc* m_storeGate;
-
   CaloTowerSeg m_theTowerSeg;
 
-  bool m_cacheValid;
+  //bool m_cacheValid;
 
   ToolHandle<IGeoAlignTool> m_caloAlignTool;
   

Calorimeter/CaloUtils/src/CaloLCDeadMaterialTool.cxx

@@ -44,7 +44,9 @@ CaloLCDeadMaterialTool::CaloLCDeadMaterialTool(const std::string& type,
     m_MaxChangeInCellWeight(30.0),
     m_useHadProbability(false),
     m_interpolate(false),
-    m_absOpt(false)
+    m_absOpt(false),
+    m_cls_unweighted_energy(0),
+    m_dm_total(0)
 {
   declareInterface<IClusterCellWeightTool>(this);
   declareProperty("HadDMCoeffKey",m_key);

Calorimeter/CaloUtils/src/CaloLCWeightTool.cxx

@@ -44,6 +44,8 @@ CaloLCWeightTool::CaloLCWeightTool(const std::string& type,
     m_signalOverNoiseCut(2),
     m_useHadProbability(false),
     m_interpolate(false),
+    m_calo_id(nullptr),
+    m_calo_dd_man(nullptr),
     m_noiseTool("CaloNoiseTool/CaloNoiseToolDefault")
 {
 

Calorimeter/CaloUtils/src/CaloTopoTowerBuilderTool.cxx

@@ -41,7 +41,16 @@ CaloTopoTowerBuilderTool::CaloTopoTowerBuilderTool(const std::string& name,
 					   const std::string& type,
 					   const IInterface* parent)
   : CaloTopoTowerBuilderToolBase(name,type,parent),
-    m_useNoiseTool(false)
+    m_minimumCellEnergy(0),
+    m_minimumClusterEnergy(0),
+    m_useCellWeights(false),
+    m_useNoiseTool(false),
+    m_usePileUpNoise(false),
+    m_noiseSigma(0),
+    m_cellESignificanceThreshold(0),
+    m_caloSelection(false),
+    m_calo_dd_man(nullptr),
+    m_calo_id(nullptr)
 {
   declareInterface<ICaloTopoTowerBuilderToolBase>(this);    
 }

Calorimeter/CaloUtils/src/CaloTopoTowerBuilderToolBase.cxx

@@ -27,25 +27,7 @@ CaloTopoTowerBuilderToolBase::~CaloTopoTowerBuilderToolBase()
 
 StatusCode CaloTopoTowerBuilderToolBase::initialize()
 {
-  ///////////////////////
-  // Allocate Services //
-  ///////////////////////
-
-  // StoreGate
-  StatusCode checkOut = service("StoreGateSvc",m_storeGate);
-  if ( checkOut.isFailure() )
-    {
-      msg(MSG::ERROR)
-	  << "cannot allocate StoreGate service"
-	  << endreq;
-    }
-  // invoke internal initialization
-  else 
-    {
-      checkOut = this->initializeTool();
-    }
- 
-  return checkOut;
+  return this->initializeTool();
 }
 
 void CaloTopoTowerBuilderToolBase::setTowerSeg(const CaloTowerSeg& theTowerSeg)

Calorimeter/CaloUtils/src/LocalNoiseSuppressionTool.cxx

@@ -43,7 +43,11 @@ LocalNoiseSuppressionTool::LocalNoiseSuppressionTool(const std::string& type,
     m_caloCellContainerName(""), 
     m_testStatistic("max"), m_neighborOption("super3D"),
     m_s0(1.05), m_s1(0.017), m_o0(1.1), m_o1(0.035),
-    m_noiseTool("CaloNoiseTool/CaloNoiseToolDefault")
+    m_nNeighbors(0),
+    m_noiseTool("CaloNoiseTool/CaloNoiseToolDefault"),
+    m_calo_dd_man(nullptr),
+    m_calo_id(nullptr),
+    m_caloCellContainer(nullptr)
 {
 
   declareInterface<ICellWeightTool>(this);