'CMakeLists.txt' (ZDC_SimEvent-00-00-04)

        * Tagging ZDC_SimEvent-00-00-04.
	* Fix coverity warnings: Remove badly-written (and useless)
	assignment operators.

2016-03-17  scott snyder  <snyder@bnl.gov>

        * Tagging ZDC_SimEvent-00-00-03.
	* Comply with ATLAS naming conventions.

ForwardDetectors/ZDC/ZDC_SimEvent/CMakeLists.txt

+################################################################################
+# Package: ZDC_SimEvent
+################################################################################
+
+# Declare the package name:
+atlas_subdir( ZDC_SimEvent )
+
+# Declare the package's dependencies:
+atlas_depends_on_subdirs( PUBLIC
+                          Control/CLIDSvc
+                          Control/SGTools
+                          Simulation/HitManagement )
+
+# External dependencies:
+find_package( ROOT COMPONENTS Core Tree MathCore Hist RIO pthread )
+
+# Component(s) in the package:
+atlas_add_library( ZDC_SimEvent
+                   src/*.cxx
+                   PUBLIC_HEADERS ZDC_SimEvent
+                   PRIVATE_INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
+                   LINK_LIBRARIES SGTools HitManagement
+                   PRIVATE_LINK_LIBRARIES ${ROOT_LIBRARIES} )
+
+atlas_add_dictionary( ZDC_SimEventDict
+                      ZDC_SimEvent/ZDC_SimEventDict.h
+                      ZDC_SimEvent/selection.xml
+                      INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
+                      LINK_LIBRARIES ${ROOT_LIBRARIES} SGTools HitManagement ZDC_SimEvent )
+

ForwardDetectors/ZDC/ZDC_SimEvent/ZDC_SimEvent/ZDC_SimPixelHit.h

@@ -11,30 +11,28 @@ class ZDC_SimPixelHit
   
   ZDC_SimPixelHit() { //must have a constructor with no argument as otherwise there is some problem from the ".xml" file
     
-    Side = -1; ModNo = -1; PixNo = -1; Edep = -1; Nphotons = -1;
+    m_Side = -1; m_ModNo = -1; m_PixNo = -1; m_Edep = -1; m_Nphotons = -1;
   }
   
   ZDC_SimPixelHit(int side, int modno, int pixno, int nphot, double edep) {
     
-    Side = side; ModNo = modno; PixNo = pixno; Nphotons = nphot; Edep = edep;
+    m_Side = side; m_ModNo = modno; m_PixNo = pixno; m_Nphotons = nphot; m_Edep = edep;
   }
   
-  int    GetSide()     const { return Side; }
-  int    GetMod()      const { return ModNo; }
-  int    GetPix()      const { return PixNo; }
-  double GetEdep()     const { return Edep; }
-  int    GetNPhotons() const { return Nphotons; }
-
-  const ZDC_SimPixelHit& operator = (const ZDC_SimPixelHit&);
+  int    GetSide()     const { return m_Side; }
+  int    GetMod()      const { return m_ModNo; }
+  int    GetPix()      const { return m_PixNo; }
+  double GetEdep()     const { return m_Edep; }
+  int    GetNPhotons() const { return m_Nphotons; }
 
   int   operator == (const ZDC_SimPixelHit&) const;
   bool  operator <  (const ZDC_SimPixelHit&) const;
 
  private:
   
-  int    Side, ModNo, PixNo;
-  int    Nphotons;
-  double Edep;
+  int    m_Side, m_ModNo, m_PixNo;
+  int    m_Nphotons;
+  double m_Edep;
 };
 
 #endif

ForwardDetectors/ZDC/ZDC_SimEvent/ZDC_SimEvent/ZDC_SimStripHit.h

@@ -12,29 +12,27 @@ class ZDC_SimStripHit
   
   ZDC_SimStripHit() { // must have a constructor with no argument as otherwise there is some problem from the ".xml" file
     
-    Side = -1; ModNo = -1; Edep =-1; Nphotons = -1;
+    m_Side = -1; m_ModNo = -1; m_Edep =-1; m_Nphotons = -1;
   }
   
   ZDC_SimStripHit(int side, int modno, int nphot, double edep) {
     
-    Side = side; ModNo = modno; Edep = edep; Nphotons = nphot;
+    m_Side = side; m_ModNo = modno; m_Edep = edep; m_Nphotons = nphot;
   }
   
-  int    GetSide()     const { return Side; }
-  int    GetMod()      const { return ModNo; }
-  double GetEdep()     const { return Edep; }
-  int    GetNPhotons() const { return Nphotons; }
-
-  const ZDC_SimStripHit& operator = (const ZDC_SimStripHit&);
+  int    GetSide()     const { return m_Side; }
+  int    GetMod()      const { return m_ModNo; }
+  double GetEdep()     const { return m_Edep; }
+  int    GetNPhotons() const { return m_Nphotons; }
 
   int   operator == (const ZDC_SimStripHit&) const;
   bool  operator  < (const ZDC_SimStripHit&) const;
 
   private:
   
-  int    Side, ModNo; // The side and Module_No to which this entry corresponds to
-  int    Nphotons;    // The number of detected cherenkov photons in this TimeBin
-  double Edep;        // The total energy of all the cherenkov photons in this TimeBin
+  int    m_Side, m_ModNo; // The side and Module_No to which this entry corresponds to
+  int    m_Nphotons;    // The number of detected cherenkov photons in this TimeBin
+  double m_Edep;        // The total energy of all the cherenkov photons in this TimeBin
 };
 
 #endif

ForwardDetectors/ZDC/ZDC_SimEvent/src/ZDC_SimPixelHit.cxx

@@ -4,24 +4,13 @@
 
 #include "ZDC_SimEvent/ZDC_SimPixelHit.h"
 
-const ZDC_SimPixelHit& ZDC_SimPixelHit::operator = (const ZDC_SimPixelHit& simhit) {
-  
-  Side           = simhit.Side;
-  ModNo          = simhit.ModNo;
-  PixNo          = simhit.PixNo;
-  Nphotons       = simhit.Nphotons;
-  Edep           = simhit.Edep;
-  
-  return *this;
-}
-
 int ZDC_SimPixelHit::operator == (const ZDC_SimPixelHit& simhit) const { return (this==&simhit) ? 1 : 0; }
 
 bool ZDC_SimPixelHit::operator < (const ZDC_SimPixelHit&    rhs) const { 
   
-  if (Side  < rhs.Side)  return true;
-  if (ModNo < rhs.ModNo) return true;
-  if (PixNo < rhs.PixNo) return true;
+  if (m_Side  < rhs.m_Side)  return true;
+  if (m_ModNo < rhs.m_ModNo) return true;
+  if (m_PixNo < rhs.m_PixNo) return true;
 
   return false;
 }

ForwardDetectors/ZDC/ZDC_SimEvent/src/ZDC_SimStripHit.cxx

@@ -4,22 +4,12 @@
 
 #include "ZDC_SimEvent/ZDC_SimStripHit.h"
 
-const ZDC_SimStripHit& ZDC_SimStripHit::operator = (const ZDC_SimStripHit& simhit) {
-  
-  Side           = simhit.Side;
-  ModNo          = simhit.ModNo;
-  Nphotons       = simhit.Nphotons;
-  Edep           = simhit.Edep;
-  
-  return *this;
-}
-
 int ZDC_SimStripHit::operator == (const ZDC_SimStripHit& simhit) const { return (this==&simhit) ? 1 : 0; }
 
 bool ZDC_SimStripHit::operator < (const ZDC_SimStripHit&    rhs) const { 
 
-  if (Side  < rhs.Side)  return true;
-  if (ModNo < rhs.ModNo) return true;
+  if (m_Side  < rhs.m_Side)  return true;
+  if (m_ModNo < rhs.m_ModNo) return true;
 
   return false;
 }