Merge branch 'cppcheck.HIGlobal-20240529' into 'main'

HIGlobal: Fix cppcheck 2.14 warnings.

See merge request !71810

Reconstruction/HeavyIonRec/HIGlobal/HIGlobal/IHIEventShapeFiller.h

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef __INTERFACE_HIEVENTSHAPEMODIFIER_H__
@@ -34,7 +34,7 @@ public:
 
   virtual StatusCode fillCollectionFromCells(std::unique_ptr<xAOD::HIEventShapeContainer>& evtShape, const SG::ReadHandleKey<CaloCellContainer>& m_cell_container_key, const EventContext& ctx) const = 0;
 
-  inline std::string getContainerName() const { return m_outputContainerName; };
+  inline const std::string& getContainerName() const { return m_outputContainerName; };
   inline void setContainerName(const std::string& cname) { m_outputContainerName = cname; };
 
 private:

Reconstruction/HeavyIonRec/HIJetRec/Root/HIJetConstituentSubtractionTool.h

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 // HIJetConstituentSubtractionTool.h
@@ -90,7 +90,7 @@ protected:
   inline SG::ReadHandleKey< xAOD::HIEventShapeContainer > EventShapeKey()  { return m_eventShapeKey; };
   //That looks useless. commented out for the moment
   //inline std::string ModulationKey() const {return m_modulation_key;};
-  inline std::string momentName() const { return m_momentName; };
+  inline const std::string& momentName() const { return m_momentName; };
   inline bool momentOnly() const { return m_momentOnly; };
 
   inline void setEventShapeKey( const SG::ReadHandleKey< xAOD::HIEventShapeContainer >& key ) { m_eventShapeKey=key; };