From 7f2625ef605cb4b122caf3e20900723a647ed1c2 Mon Sep 17 00:00:00 2001
From: Shaun Roe <shaun.roe@cern.ch>
Date: Thu, 2 May 2024 17:17:45 +0200
Subject: [PATCH] main-cppcheck_suppress-PixelCalibAlgs
main-cppcheck_suppress-PixelCalibAlgs
---
.../PixelCalibAlgs/ChargeCalibration/pixel/tools/Calib.h | 6 +++---
.../ChargeCalibration/pixel/tools/CalibFrontEndInfo.cxx | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/Calib.h b/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/Calib.h
index 5712981da537..a92f6d4d4115 100644
--- a/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/Calib.h
+++ b/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/Calib.h
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
//***********************************************************************************************
@@ -33,14 +33,14 @@
class Calib {
public:
- Calib (int whichPart, bool saveFile, std::string moduleName = "") {
+ Calib (int whichPart, bool saveFile, const std::string & moduleName = "") {
m_whichPart = whichPart;
if(saveFile){
m_savefile = saveFile;
m_wFile = std::make_unique<TFile>(m_layers.at(whichPart)+".HIST.root","RECREATE");
}
- if( std::strcmp(moduleName.c_str(), "") != 0 ){
+ if( not moduleName.empty() ){
m_runOneMOD = true;
m_testMOD = moduleName;
}
diff --git a/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/CalibFrontEndInfo.cxx b/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/CalibFrontEndInfo.cxx
index a37fb5e136d3..3c76af6aeb2e 100644
--- a/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/CalibFrontEndInfo.cxx
+++ b/InnerDetector/InDetCalibAlgs/PixelCalibAlgs/ChargeCalibration/pixel/tools/CalibFrontEndInfo.cxx
@@ -1,5 +1,5 @@
/*
- Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+ Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
*/
//***********************************************************************************************
@@ -28,6 +28,7 @@ std::stringstream CalibFrontEndInfo::printDBformat() const {
<< " " << m_SigFitParams.at(0) << " " << m_SigFitParams.at(1) ;
}
else{
+ //cppcheck-suppress invalidPrintfArgType_uint
printf( " ERROR - Is the module disabled for TOT Scan? - m_NormalFitParams.size = %2lu , m_LongFitParams.size = %2lu, m_SigFitParams.size = %2lu \n",m_NormalFitParams.size() ,m_LongFitParams.size(),m_SigFitParams.size());
mytext << "I" << m_FEid
<< " " << m_NormalThreshold << " " << m_NormalRms << " " << m_NormalNoise << " " << m_NormalIntime
--
GitLab