AtlasTest: enable flake8 and fix code

AtlasTest/ControlTest/CMakeLists.txt

@@ -106,5 +106,5 @@ atlas_add_test( test_handleTest
                 SCRIPT test/test_handleTest.sh )
 
 # Install files from the package:
-atlas_install_python_modules( python/*.py )
+atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
 atlas_install_joboptions( share/StoreGateTestCommon.txt share/*.py )

AtlasTest/ControlTest/python/test_keyStore.py

-# Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 from __future__ import print_function
 
 from AthenaCommon.Constants import VERBOSE,INFO
-from AthenaCommon.KeyStore import CfgItemList, CfgKeyStore
+from AthenaCommon.KeyStore import CfgKeyStore
 
 
 from AthenaCommon.Logging import logging

AtlasTest/PyAthenaTests/CMakeLists.txt

@@ -4,7 +4,7 @@
 atlas_subdir( PyAthenaTests )
 
 # Install files from the package:
-atlas_install_python_modules( python/*.py )
+atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
 atlas_install_joboptions( share/*.py )
 atlas_install_runtime( test/*.ref )
 atlas_install_scripts( test/*.py )

AtlasTest/PyAthenaTests/python/Lib.py

@@ -67,7 +67,7 @@ class PyRecord( PyAthena.Alg ):
         allGood = True
         particles = PyAthena.AthExParticles()
         ## fill-in particles:
-        for i in xrange(10):
+        for i in range(10):
             particles.push_back( PyAthena.AthExParticle(i,i,i,i) )
             
         if _record(particles, self.particles) != StatusCode.Success:
@@ -564,7 +564,7 @@ class ClusterExAlg(PyAthena.Alg):
         _clusE   = self.hsvc['/py/clusE'].Fill
         _clusEta = self.hsvc['/py/clusEta'].Fill
 
-        from ROOT import CaloClusterMoment
+        from ROOT import CaloClusterMoment  # noqa: F401
         from ROOT import Double as RDouble
         
         for i,cluster in enumerate(clusters):
@@ -596,7 +596,6 @@ class ClusterExAlg(PyAthena.Alg):
     def finalize(self):
         _info = self.msg.info
         _info('==> finalize')
-        import AthenaCommon.Constants
         clusE   = self.hsvc['/py/clusE']
         clusEta = self.hsvc['/py/clusEta']
 
@@ -666,7 +665,7 @@ class AresClusterExAlg(PyAthena.Alg):
         _clusE   = self.hsvc['/py/clusE'].Fill
         _clusEta = self.hsvc['/py/clusEta'].Fill
 
-        from ROOT import CaloClusterMoment
+        from ROOT import CaloClusterMoment  # noqa: F401
         from ROOT import Double as RDouble
         
         for i,cluster in enumerate(clusters):
@@ -698,7 +697,6 @@ class AresClusterExAlg(PyAthena.Alg):
     def finalize(self):
         _info = self.msg.info
         _info('==> finalize')
-        import AthenaCommon.Constants
         clusE   = self.hsvc['/py/clusE']
         clusEta = self.hsvc['/py/clusEta']
 

AtlasTest/PyAthenaTests/python/my_new_execute.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 from math import log10
 from PyAthenaTests.Lib import _patch
@@ -22,7 +22,7 @@ def new_execute(self):
     _clusE   = self.hsvc['/py/clusE'].Fill
     _clusEta = self.hsvc['/py/clusEta'].Fill
 
-    from ROOT import CaloClusterMoment
+    from ROOT import CaloClusterMoment  # noqa: F401
     from ROOT import Double as RDouble
 
     for i,cluster in enumerate(clusters):

AtlasTest/TestTools/CMakeLists.txt

@@ -18,7 +18,7 @@ else()
 endif()
 
 # Install files from the package:
-atlas_install_python_modules( python/*.py )
+atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
 atlas_install_joboptions( share/*.py )
 atlas_install_scripts( share/post.sh share/nopost.sh )
 

AtlasTest/TestTools/python/iobench.py

@@ -105,7 +105,7 @@ class Bench(object):
 
         for i in range(self.nTimes):
             iStart = getResources()
-            out = fct( *args, **kwargs )
+            fct( *args, **kwargs )
             self.data.append( getResources() - iStart )
             pass
 
@@ -143,7 +143,6 @@ class Bench(object):
 ## ---- Athena specific part ----
 ##
 
-import os
 from configparser import ConfigParser
 class ChronoStatsOutputParser( ConfigParser ):
     """Subclass and specialize ConfigParser to make it case-sensitive
@@ -326,7 +325,6 @@ def doPostCheck( validationName, refFileName, chkFileName, chkFilter ):
 
 ###-----------------------------------------------------
 from AthenaCommon import ChapPy
-from tempfile import NamedTemporaryFile
 class AthBench(object):
 
     def __init__( self,
@@ -356,7 +354,7 @@ class AthBench(object):
         for i in range(self.nTimes):
             self.athena.logFile = open( "%s.%s" % (self.logFileName,i), "w" )
             iStart = getResources()
-            out = self.athena.run()
+            self.athena.run()
             self.data.append( getResources() - iStart )
             self.chronoStats.append( ChronoStatReport(self.ioStatsFileName) )
             pass