Merge branch 'cppcheck.BPhysTools-20240530' into 'main'

BPhysTools: Fix cppcheck warnings.

See merge request !71848

PhysicsAnalysis/BPhys/BPhysTools/Root/BPhysTrackVertexMapTool.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
-// $Id: $
-
 // system include:
 #include "boost/format.hpp"
 #include "boost/tokenizer.hpp"
@@ -505,7 +503,7 @@ namespace xAOD {
     if ( withMasses && m_hypoName != "__NONE__" ) {
       // vector of possible hypo names
       std::vector<std::string> hypoNames = getTokens(m_hypoName, "|;/");
-      for ( auto hypoName : hypoNames ) {
+      for ( const std::string& hypoName : hypoNames ) {
 	BPhysHypoHelper bhh(hypoName, vtx);
 	float bMass       = bhh.mass();
 	float bMassErr    = bhh.massErr();

PhysicsAnalysis/BPhys/BPhysTools/Root/SimpleEncrypter.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 // system include:
@@ -387,8 +387,12 @@ namespace xAOD {
     if ( sizeof(float)*CHAR_BIT >= r ) {
       // check whether a quick conversion is possible
       if ( sizeof(float) == sizeof(int) ) {
-        float* p = reinterpret_cast<float*>(&val);
-        res = *p;
+        union {
+          float f;
+          ULLI_t i;
+        } ficnv;
+        ficnv.i = val;
+        res = ficnv.f;
       } else {
         // do a slow conversion
         char* pres = reinterpret_cast<char*>(&res);