VP1AODSystems: Fix cppcheck 2.14 warnings.

VP1AODSystems: Fix cppcheck 2.14 warnings.

Copying values in range-for.
Prefer returning const references to members rather than copies.

graphics/VP1/VP1Systems/VP1AODSystems/src/IParticleCollHandleBase.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -196,7 +196,7 @@ bool IParticleCollHandleBase::cut(AODHandleBase* ahand)
         double phi = VP1LinAlgUtils::phiFromXY(mom.x(), mom.y() );
         messageVerbose("value oh handle's phi: " + QString::number(phi));
         bool ok(false);
-        for (VP1Interval phirange : m_cut_allowedPhi) {
+        for (const VP1Interval& phirange : m_cut_allowedPhi) {
           if (phirange.contains(phi)||phirange.contains(phi+2*M_PI)||phirange.contains(phi-2*M_PI)) {
             ok = true;
             break;

graphics/VP1/VP1Systems/VP1AODSystems/src/IParticleCollHandleBase.h

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -108,8 +108,8 @@ public Q_SLOTS:
   void setCutAllowedPhi(const QList<VP1Interval>&);
 
   //getters
-  VP1Interval getCutAllowedPt() {return m_cut_allowedPtSq; };
-  VP1Interval getCutAllowedEta() {return m_cut_allowedEta; };
+  const VP1Interval& getCutAllowedPt() {return m_cut_allowedPtSq; };
+  const VP1Interval& getCutAllowedEta() {return m_cut_allowedEta; };
   QList<VP1Interval> getCutAllowedPhi() {return m_cut_allowedPhi; };
   bool getPtAllowall() {return m_cut_pt_allowall; };
   bool getEtaAllowall() {return m_cut_eta_allowall; };

graphics/VP1/VP1Systems/VP1AODSystems/src/IParticleCollHandle_CaloCluster.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -519,7 +519,7 @@ bool IParticleCollHandle_CaloCluster::cut(AODHandleBase* c) {
     if (!getPhiAllowall() ) {
       double phi = handle->phi();
       bool ok(false);
-      for (VP1Interval phirange :  getCutAllowedPhi() ) {
+      for (const VP1Interval& phirange :  getCutAllowedPhi() ) {
         messageVerbose("object's phi, phiCut, PhiAll: " + QString::number(phi)  + " - " + phirange.toString() + " - " + QString::number(int(getPhiAllowall())) );
         if (phirange.contains(phi)||phirange.contains(phi+2*M_PI)||phirange.contains(phi-2*M_PI)) {
           ok = true;

graphics/VP1/VP1Systems/VP1AODSystems/src/IParticleCollHandle_Jet.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -557,7 +557,7 @@ bool IParticleCollHandle_Jet::cut(AODHandleBase* c) {
     if (!getPhiAllowall() ) {
       double phi = handle->phi();
       bool ok(false);
-      for (VP1Interval phirange : getCutAllowedPhi() ) {
+      for (const VP1Interval& phirange : getCutAllowedPhi() ) {
         messageVerbose("jet's phi, phiCut, PhiAll: " + QString::number(phi)  + " - " + phirange.toString() + " - " + QString::number(int(getPhiAllowall())) );
         if (phirange.contains(phi)||phirange.contains(phi+2*M_PI)||phirange.contains(phi-2*M_PI)) {
           ok = true;

graphics/VP1/VP1Systems/VP1AODSystems/src/MissingEtCollHandle.cxx

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -475,7 +475,7 @@ bool MissingEtCollHandle::cut(AODHandleBase* c) {
     		if (!getPhiAllowall() ) {
     			double phi = handle->phi();
     			bool ok(false);
-    			for (VP1Interval phirange : getCutAllowedPhi() ) {
+    			for (const VP1Interval& phirange : getCutAllowedPhi() ) {
     				messageVerbose("MET phi, phiCut, PhiAll: " + QString::number(phi)  + " - " + phirange.toString() + " - " + QString::number(int(getPhiAllowall())) );
     				if (phirange.contains(phi)||phirange.contains(phi+2*M_PI)||phirange.contains(phi-2*M_PI)) {
     					ok = true;

graphics/VP1/VP1Systems/VP1AODSystems/src/VertexCollHandle.h

 /*
-  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2024 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -121,9 +121,9 @@ public Q_SLOTS:
   void setVertexSize(int);
 
   //getters
-  VP1Interval getCutAllowedY() {return m_cut_allowedY; };
-  VP1Interval getCutAllowedZ() {return m_cut_allowedZ; };
-  VP1Interval getCutAllowedR() {return m_cut_allowedR; };
+  const VP1Interval& getCutAllowedY() {return m_cut_allowedY; };
+  const VP1Interval& getCutAllowedZ() {return m_cut_allowedZ; };
+  const VP1Interval& getCutAllowedR() {return m_cut_allowedR; };
   bool        getYAllowall() {return m_cut_y_allowall; };
   bool        getZAllowall() {return m_cut_z_allowall; };
   bool        getRAllowall() {return m_cut_r_allowall; };